Page MenuHomePhabricator

Fix URL path of MediaWiki repository on Special:Version
Closed, ResolvedPublic

Description

This was noticed after the recent upgrade of Wikimedia wikis (currently running on r56620). On [[Special:Version]], please fix the URL of MediaWiki repository.

Example of current URLs:
http://svn.wikimedia.org/viewvc/mediawiki/branches/wmf-deployment/?revision=56620

Example of corrected URLs:
http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/?pathrev=56620


Version: 1.16.x
Severity: enhancement
URL: http://en.wikipedia.org/wiki/Special:Version

Details

Reference
bz20730

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:56 PM
bzimport set Reference to bz20730.
bzimport added a subscriber: Unknown Object (MLST).
Meno25 created this task.Sep 18 2009, 9:54 PM
brion added a comment.Sep 18 2009, 9:55 PM

It would be incorrect to point at trunk instead of the actual branch used.

(In reply to comment #0)
(Damn. I should not submit bugs when I am not fully awake.)

Just change "/?revision=" to "?pathrev=" in URLs.

Huji added a comment.Sep 20 2009, 9:22 AM

I guess that is because of this section of SpecialVersion.php (lines 480 to 485).

if ( substr( $pathRelativeToRepo, 0, 6 ) == '/trunk' ) {
$viewvc .= '/?pathrev=';
} else {
// Avoids 404 error using pathrev when it does not found
$viewvc .= '/?revision=';
}

brion added a comment.Sep 21 2009, 4:34 PM

Done in r56713