Page MenuHomePhabricator

Edit Cards v2: instrumentation post-deployment data checks
Closed, ResolvedPublic

Description

Overview

This task involves the work with making sure we are logging data in such a way that we will be able to track the events in the editing link and citation workflows we implemented in T221305 and T221249.

Checks

"Done"

  • Confirm we are properly logging the events listed in the "Checks" section above.

Event Timeline

JTannerWMF added a subscriber: JTannerWMF.

Waiting for the release of V2

ppelberg updated the task description. (Show Details)

Just updated the task description to include the additional tracking that was added in Edit Cards v2 and will subsequently need to be checked to complete this task.

@Esanders, are you able to confirm the "Checks" section in the task description includes all of the additional instrumentation that was added to Edit Cards v2? It looks like this is the patch where that instrumentation work happened (thanks @matmarex), but I wasn't sure if there was anything else: https://gerrit.wikimedia.org/r/c/VisualEditor/VisualEditor/+/525139

@Neil_P._Quinn_WMF, pending sign off from Ed, this task should now include all of the information you need to make sure the additional logging events we added to Edit Cards v2 are being logged correctly.

@Esanders, are you able to confirm the "Checks" section in the task description includes all of the additional instrumentation that was added to Edit Cards v2? It looks like this is the patch where that instrumentation work happened (thanks @matmarex), but I wasn't sure if there was anything else: https://gerrit.wikimedia.org/r/c/VisualEditor/VisualEditor/+/525139

Confirmed after a conversation with Ed and David L.: the "Checks" section in the task description includes all of the additional instrumentation that was added to Edit Cards v2

@Neil_P._Quinn_WMF, pending sign off from Ed, this task should now include all of the information you need to make sure the additional logging events we added to Edit Cards v2 are being logged correctly.

@Neil_P._Quinn_WMF, the task description includes all of the information [I think] you will need to make sure the additional logging events we added to Edit Cards v2 are being logged correctly.

Paired with @Neil_P._Quinn_WMF to confirm that the additional logging events are being logged correctly. We see the close context events starting at the end of July as expected for a variety of features.

Dates through 8/10 below:

dateCount of close context actions
2019-07-312.0
2019-08-01390.0
2019-08-023112.0
2019-08-033096.0
2019-08-043279.0
2019-08-053110.0
2019-08-063107.0
2019-08-073181.0
2019-08-083138.0
2019-08-093236.0
2019-08-103584.0

The transclusion and link/internal features currently have the most closed context events logged.

FeatureCount of close context actions
transclusion32470.0
link/internal19600.0
mergeCells2794.0
cite-web2154.0
reference1566.0
mwMedia1215.0
link1156.0
referencesList1068.0
comment395.0
link/mwNumberedExternal343.0

All looks good! Please see code and results in the repo.
Notebook

Let us know if you have any questions.

Thanks for getting on this so quickly @MNeisler and @Neil_P._Quinn_WMF !

@ppelberg closing as resolved but reopen if needed