Page MenuHomePhabricator
Create Task
Maniphest T227461

PHPRedis module >= 5.0.0 throws deprecation warnings for delete().
Closed, ResolvedPublic
Actions

Description

The PHPRedis module >= 5.0.0 marks Redis::delete() as deprecated and throws a deprecated warning with every call

Details

SubjectRepoBranchLines +/-
objectcache: avoid using deprecated phpredis::delete() aliasmediawiki/coreREL1_32+3 -2
Avoid using deprecated phpredis::delete() aliasmediawiki/coremaster+1 -1
objectcache: avoid using deprecated phpredis::delete() aliasmediawiki/coreREL1_31+3 -2
Avoid using deprecated phpredis::delete() aliasmediawiki/coreREL1_33+1 -1
Avoid using deprecated phpredis::delete() aliasmediawiki/coreREL1_31+1 -1
Avoid using deprecated phpredis::delete() aliasmediawiki/coreREL1_34+1 -1
Avoid using deprecated phpredis::delete() aliasmediawiki/coreREL1_32+1 -1
Handle deprecated 'delete' alias with an alias function. This resolves phpredis >= 5.0.0 from throwing deprecation warnings.mediawiki/coremaster+10 -0
objectcache: avoid using deprecated phpredis::delete() aliasmediawiki/coreREL1_33+4 -3
Customize query in gerrit

Related Objects

Event Timeline

Alexia created this task.Jul 8 2019, 11:41 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 8 2019, 11:41 AM
gerritbot added a comment.Jul 8 2019, 11:48 AM

Change 521257 had a related patch set uploaded (by Alexia; owner: Alexia):
[mediawiki/core@master] Handle deprecated 'delete' alias with an alias function. This resolves phpredis >= 5.0.0 from throwing deprecation warnings.

https://gerrit.wikimedia.org/r/521257

gerritbot added a project: Patch-For-Review.Jul 8 2019, 11:48 AM
Alexia renamed this task from PHPRedis >= 5.0.0 throws deprecation warnings for delete(). to PHPRedis module >= 5.0.0 throws deprecation warnings for delete()..Jul 8 2019, 11:55 AM
Alexia updated the task description. (Show Details)
Krinkle moved this task from General to libs/objectcache (libs/Redis) on the MediaWiki-libs-BagOStuff board.Aug 29 2019, 1:42 AM
Krinkle moved this task from libs/objectcache (libs/Redis) to libs/objectcache on the MediaWiki-libs-BagOStuff board.Aug 29 2019, 1:47 AM
Paladox merged a task: T230273: Deprecated: Function Redis::delete() is deprecated in /srv/mediawiki/w/includes/libs/redis/RedisConnRef.php on line 131.Aug 31 2019, 9:19 PM
Paladox added subscribers: Paladox, Reception123, Umherirrender, aaron.
gerritbot added a comment.Aug 31 2019, 9:20 PM

Change 533714 had a related patch set uploaded (by Paladox; owner: Aaron Schulz):
[mediawiki/core@REL1_33] objectcache: avoid using deprecated phpredis::delete() alias

https://gerrit.wikimedia.org/r/533714

Paladox added a comment.Aug 31 2019, 9:20 PM

Is fixed with https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/527212/ but backported to REL1_33 with https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/533714/

gerritbot added a comment.Sep 1 2019, 11:18 PM

Change 533714 merged by jenkins-bot:
[mediawiki/core@REL1_33] objectcache: avoid using deprecated phpredis::delete() alias

https://gerrit.wikimedia.org/r/533714

ReleaseTaggerBot added a project: MW-1.33-notes.Sep 2 2019, 12:00 AM
gerritbot added a comment.Dec 2 2019, 10:51 PM

Change 521257 abandoned by Reedy:
Handle deprecated 'delete' alias with an alias function. This resolves phpredis >= 5.0.0 from throwing deprecation warnings.

https://gerrit.wikimedia.org/r/521257

Reedy updated the task description. (Show Details)Dec 2 2019, 10:54 PM
gerritbot added a comment.Dec 2 2019, 10:56 PM

Change 554176 had a related patch set uploaded (by Paladox; owner: Paladox):
[mediawiki/core@master] Avoid using deprecated phpredis::delete() alias

https://gerrit.wikimedia.org/r/554176

gerritbot added a comment.Dec 2 2019, 10:58 PM

Change 554179 had a related patch set uploaded (by Reedy; owner: Paladox):
[mediawiki/core@REL1_34] Avoid using deprecated phpredis::delete() alias

https://gerrit.wikimedia.org/r/554179

gerritbot added a comment.Dec 2 2019, 10:58 PM

Change 554180 had a related patch set uploaded (by Reedy; owner: Paladox):
[mediawiki/core@REL1_33] Avoid using deprecated phpredis::delete() alias

https://gerrit.wikimedia.org/r/554180

gerritbot added a comment.Dec 2 2019, 10:59 PM

Change 554181 had a related patch set uploaded (by Reedy; owner: Paladox):
[mediawiki/core@REL1_32] Avoid using deprecated phpredis::delete() alias

https://gerrit.wikimedia.org/r/554181

gerritbot added a comment.Dec 2 2019, 10:59 PM

Change 554182 had a related patch set uploaded (by Reedy; owner: Paladox):
[mediawiki/core@REL1_31] Avoid using deprecated phpredis::delete() alias

https://gerrit.wikimedia.org/r/554182

gerritbot added a comment.Dec 2 2019, 11:03 PM

Change 554123 had a related patch set uploaded (by Paladox; owner: Paladox):
[mediawiki/services/jobrunner@master] Avoid using deprecated phpredis::delete() alias

https://gerrit.wikimedia.org/r/554123

gerritbot added a comment.Dec 2 2019, 11:05 PM

Change 554123 abandoned by Paladox:
Avoid using deprecated phpredis::delete() alias

https://gerrit.wikimedia.org/r/554123

gerritbot added a comment.Dec 2 2019, 11:06 PM

Change 554181 merged by jenkins-bot:
[mediawiki/core@REL1_32] Avoid using deprecated phpredis::delete() alias

https://gerrit.wikimedia.org/r/554181

gerritbot added a comment.Dec 2 2019, 11:07 PM

Change 554179 merged by jenkins-bot:
[mediawiki/core@REL1_34] Avoid using deprecated phpredis::delete() alias

https://gerrit.wikimedia.org/r/554179

gerritbot added a comment.Dec 2 2019, 11:10 PM

Change 554183 had a related patch set uploaded (by Reedy; owner: Aaron Schulz):
[mediawiki/core@REL1_32] objectcache: avoid using deprecated phpredis::delete() alias

https://gerrit.wikimedia.org/r/554183

gerritbot added a comment.Dec 2 2019, 11:13 PM

Change 554184 had a related patch set uploaded (by Reedy; owner: Aaron Schulz):
[mediawiki/core@REL1_31] objectcache: avoid using deprecated phpredis::delete() alias

https://gerrit.wikimedia.org/r/554184

gerritbot added a comment.Dec 2 2019, 11:22 PM

Change 554182 merged by jenkins-bot:
[mediawiki/core@REL1_31] Avoid using deprecated phpredis::delete() alias

https://gerrit.wikimedia.org/r/554182

gerritbot added a comment.Dec 2 2019, 11:26 PM

Change 554180 merged by jenkins-bot:
[mediawiki/core@REL1_33] Avoid using deprecated phpredis::delete() alias

https://gerrit.wikimedia.org/r/554180

gerritbot added a comment.Dec 2 2019, 11:27 PM

Change 554176 merged by jenkins-bot:
[mediawiki/core@master] Avoid using deprecated phpredis::delete() alias

https://gerrit.wikimedia.org/r/554176

gerritbot added a comment.Dec 2 2019, 11:32 PM

Change 554184 merged by jenkins-bot:
[mediawiki/core@REL1_31] objectcache: avoid using deprecated phpredis::delete() alias

https://gerrit.wikimedia.org/r/554184

gerritbot added a comment.Dec 2 2019, 11:37 PM

Change 554183 merged by jenkins-bot:
[mediawiki/core@REL1_32] objectcache: avoid using deprecated phpredis::delete() alias

https://gerrit.wikimedia.org/r/554183

gerritbot added a comment.Dec 2 2019, 11:37 PM

Change 554123 restored by Paladox:
Avoid using deprecated phpredis::delete() alias

https://gerrit.wikimedia.org/r/554123

ReleaseTaggerBot added projects: MW-1.32-notes, MW-1.31-release-notes, MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), MW-1.34-notes.Dec 3 2019, 12:00 AM
Krinkle closed this task as Resolved.EditedDec 4 2019, 2:23 AM
Krinkle subscribed.

Usage within MediaWiki core (eg. libs/objectcache), which this task was for, has been resolved in master, deployed, and and backported.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL