Page MenuHomePhabricator

History page needs a placeholder when no revisions can be shown
Closed, ResolvedPublic

Description

When you visit history of a page and apply some filters (example), you will see just the filter menu and explanations of some markers.
There should be some placeholder explaining why there are no results.

obrazek.png (632×1 px, 37 KB)

Solution:

See also T225573: [Bug] History action's "Filter revisions" form should remain visible when a filter is applied.

QA steps

  • A message should inform you that no matching revisions were found.
  • Click filter revisions and remove "sillyqa" from the input box
  • Check that the message doesn't show and there are results

QA Results - Beta

ACStatusDetails
1T227578#6037273
2T227578#6037273

QA Results - Prod cawiki

ACStatusDetails
1T227578#6042110
2T227578#6042110

Event Timeline

matej_suchanek updated the task description. (Show Details)
srishakatux added a subscriber: srishakatux.

@matej_suchanek I've a newbie question - this task would require all changes to MediaWiki core only, right?

Change 577554 had a related patch set uploaded (by Sohom Datta; owner: Sohom Datta):
[mediawiki/core@master] Added message to be displayed when query returns no revision

https://gerrit.wikimedia.org/r/577554

@matej_suchanek I've updated the patch based on your recommendations, sorry for the sloppy work on the last patch set, I somehow misinterpreted/misread your comments...

No problem, you are doing well. Sorry for any confusion.

@alexhollender, @Jdlrobson - sorry for the delay. This seems ok to me.

Change 577554 merged by jenkins-bot:
[mediawiki/core@master] Added message to be displayed when query returns no revision

https://gerrit.wikimedia.org/r/577554

ovasileva added a subscriber: Soda.

Test Result - Beta

Status: ✅ PASS
OS: macOS Catalina
Browser: Chrome
Device: MBP
Emulated Device: iPhoneX

Test Artifact(s):

QA steps

Visit https://en.wikipedia.beta.wmflabs.org/w/index.php?date-range-to=&tagfilter=sillyqa&title=Main_Page&action=history
✅ AC1: A message should inform you that no matching revisions were found.

en.wikipedia.beta.wmflabs.org_w_index.php_date-range-to=&tagfilter=sillyqa&title=Main_Page&action=history(iPad).png (2×1 px, 284 KB)

Click filter revisions and remove "sillyqa" from the input box
✅ AC2: Check that the message doesn't show and there are results
en.wikipedia.beta.wmflabs.org_w_index.php_title=Main_Page&action=history(iPad).png (2×1 px, 792 KB)

Edtadros added a subscriber: Edtadros.

Test Result - Prod cawiki

Status: ✅ PASS
OS: macOS Catalina
Browser: Chrome
Device: MBP
Emulated Device: iPhoneX

Test Artifact(s):

QA steps

Visit https://en.wikipedia.beta.wmflabs.org/w/index.php?date-range-to=&tagfilter=sillyqa&title=Main_Page&action=history
✅ AC1: A message should inform you that no matching revisions were found.
@ovasileva the message is in English. I'm not sure if this is a concern or not.

ca.wikipedia.org_w_index.php_date-range-to=&tagfilter=sillyqa&title=Main_Page&action=history(iPad).png (2×1 px, 266 KB)

Click filter revisions and remove "sillyqa" from the input box
✅ AC2: Check that the message doesn't show and there are results

ca.wikipedia.org_w_index.php_date-range-to=&tagfilter=&title=Main_Page&action=history(iPad).png (2×1 px, 730 KB)

Looks good @Edtadros - the message will get translated over time in translatewiki. Resolving this. Thanks everyone!

matej_suchanek reassigned this task from ovasileva to Soda.