Page MenuHomePhabricator

action=history shows "username removed" for anonymous editors on mediawiki.org instead of IP addresses
Closed, ResolvedPublicBUG REPORT

Description

Steps to Reproduce:
For example, see https://www.mediawiki.org/w/index.php?title=Template:Main_page/it&action=history&uselang=en

Actual Results:
IP addresses of anonymous editors should be shown.

Expected Results:
"(username removed)" is shown instead.

Details

Related Gerrit Patches:

Event Timeline

Restricted Application added subscribers: Liuxinyu970226, Aklapper. · View Herald TranscriptJul 10 2019, 12:25 PM
Reedy added a subscriber: Reedy.

IP addresses of anonymous editors should be shown.

Well, not necessarily. It is possible to suppress IP addresses like you can usernames

Special:RecentChanges and Special:Watchlist shows IP addresses, but action=history does not.

Reedy triaged this task as Unbreak Now! priority.Jul 10 2019, 12:41 PM

Looks like a .13 train blocker

I see no suppressions in the logs that could cause this issue. A bug indeed unless I'm missing something.

Aklapper renamed this task from "username removed" on mediawiki.org to action=history shows "username removed" for anonymous editors on mediawiki.org instead of IP addresses.Jul 10 2019, 1:11 PM

Change 521907 had a related patch set uploaded (by Anomie; owner: Anomie):
[mediawiki/core@master] Linker: Fix incorrect test added in Ib9816d8b

https://gerrit.wikimedia.org/r/521907

Change 521907 merged by jenkins-bot:
[mediawiki/core@master] Linker: Fix incorrect test added in Ib9816d8b

https://gerrit.wikimedia.org/r/521907

Change 521912 had a related patch set uploaded (by Jforrester; owner: Anomie):
[mediawiki/core@wmf/1.34.0-wmf.13] Linker: Fix incorrect test added in Ib9816d8b

https://gerrit.wikimedia.org/r/521912

Change 521912 merged by jenkins-bot:
[mediawiki/core@wmf/1.34.0-wmf.13] Linker: Fix incorrect test added in Ib9816d8b

https://gerrit.wikimedia.org/r/521912

Mentioned in SAL (#wikimedia-operations) [2019-07-10T18:15:52Z] <jforrester@deploy1001> Synchronized php-1.34.0-wmf.13/includes/Linker.php: T227656 Fix visibility of IPs that aren't suppressed (duration: 00m 59s)