Page MenuHomePhabricator
Create Task
Maniphest T227670

Don't show the "Welcome to Wikipedia" overlay on mobile ve
Closed, ResolvedPublic
Actions

Description

We should not show the "Welcome to Wikipedia" overlay on mobile.

We should not show this overlay for a couple of primary reasons:

  • It is not shown on mobile wikitext; we'd like to keep the onboarding experiences between default and visual as consistent as possible for the purposes of the ongoing A/B test [1]
  • We think the overlay [2], in its current state, is more disruptive to contributors than it is valuable to them

Details

This patch should be limited to mobile and visual editor.

"Done"

  • The "Welcome to Wikipedia" overlay no longer appears, for any contributors, on mobile in ve.
  1. Context where this came up: T221197#5315236
  2. "Welcome to Wikipedia overlay"

image.png (1,125×2,436 px, 386 KB)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Fix copy-paste typo in MobileArticleTargetmediawiki/extensions/VisualEditormaster+2 -2
MobileArticleTarget: Don't show the welcome dialogmediawiki/extensions/VisualEditormaster+8 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

ppelberg created this task.Jul 10 2019, 2:34 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 10 2019, 2:34 PM
ppelberg added a parent task: T227338: Test visual editor as the default mobile editor on select wikis.Jul 10 2019, 2:34 PM
gerritbot added a comment.Jul 10 2019, 6:04 PM

Change 521918 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] MobileArticleTarget: Don't show the welcome dialog

https://gerrit.wikimedia.org/r/521918

gerritbot added a project: Patch-For-Review.Jul 10 2019, 6:04 PM
matmarex added a parent task: T226262: Evaluate onboarding in mobile VE.Jul 10 2019, 6:09 PM
gerritbot added a comment.Jul 10 2019, 6:47 PM

Change 521918 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] MobileArticleTarget: Don't show the welcome dialog

https://gerrit.wikimedia.org/r/521918

Jdforrester-WMF assigned this task to matmarex.Jul 10 2019, 6:56 PM
Jdforrester-WMF moved this task from Incoming to QA on the VisualEditor (Current work) board.
ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.14; 2019-07-16).Jul 10 2019, 7:00 PM
matmarex moved this task from QA to Code review on the VisualEditor (Current work) board.Jul 10 2019, 7:04 PM
matmarex moved this task from Code review to QA on the VisualEditor (Current work) board.Jul 10 2019, 7:07 PM

(I moved it while looking at the workboard, where it was still shown in the "Ready for Pick Up" column…)

Maintenance_bot removed a project: Patch-For-Review.Jul 10 2019, 7:10 PM
Jdforrester-WMF subscribed.Jul 10 2019, 7:15 PM

:-)

gerritbot added a comment.Jul 10 2019, 8:10 PM

Change 521941 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Fix copy-paste typo in MobileArticleTarget

https://gerrit.wikimedia.org/r/521941

gerritbot added a project: Patch-For-Review.Jul 10 2019, 8:10 PM
gerritbot added a comment.Jul 10 2019, 8:49 PM

Change 521941 abandoned by Jforrester:
Fix copy-paste typo in MobileArticleTarget

Reason:
Done in I8fa3c6.

https://gerrit.wikimedia.org/r/521941

Maintenance_bot removed a project: Patch-For-Review.Jul 10 2019, 9:10 PM
ppelberg added a comment.Jul 11 2019, 12:13 AM

Awesome, @matmarex.

Esanders mentioned this in T227769: Never show the unswitchable welcome dialog.Jul 11 2019, 1:20 PM
matmarex added a project: Editing QA.Jul 15 2019, 11:27 PM
matmarex moved this task from Inbox to High Priority on the Editing QA board.Jul 15 2019, 11:32 PM
Ryasmeen edited projects, added: Verified; removed: Editing QA.Jul 26 2019, 2:58 PM
Ryasmeen moved this task from QA to Product owner review on the VisualEditor (Current work) board.
ppelberg closed this task as Resolved.Sep 3 2019, 12:04 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits