Page MenuHomePhabricator
Create Task
Maniphest T227709

PHP error from Special:ExportTranslations: "get_class() expects parameter 1 to be object, null given"
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error

Request URL: /wiki/Special:ExportTranslations? …
Request ID: XSRnzgpAMEsAAIV1JNAAAAAT

message
PHP Warning: get_class() expects parameter 1 to be object, null given
trace
#0 /srv/mediawiki/php-1.34.0-wmf.11/extensions/Translate/ffs/SimpleFFS.php(274): MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/php-1.34.0-wmf.11/extensions/Translate/ffs/SimpleFFS.php(234): SimpleFFS->tryReadSource(string, MessageCollection)
#2 /srv/mediawiki/php-1.34.0-wmf.11/extensions/Translate/specials/SpecialExportTranslations.php(198): SimpleFFS->writeIntoVariable(MessageCollection)
#3 /srv/mediawiki/php-1.34.0-wmf.11/extensions/Translate/specials/SpecialExportTranslations.php(49): SpecialExportTranslations->doExport()
#4 /srv/mediawiki/php-1.34.0-wmf.11/includes/specialpage/SpecialPage.php(571): SpecialExportTranslations->execute(NULL)
#5 /srv/mediawiki/php-1.34.0-wmf.11/includes/specialpage/SpecialPageFactory.php(581): SpecialPage->run(NULL)
#6 /srv/mediawiki/php-1.34.0-wmf.11/includes/MediaWiki.php(288): MediaWiki\Special\SpecialPageFactory->executePath(Title, RequestContext)
#7 /srv/mediawiki/php-1.34.0-wmf.11/includes/MediaWiki.php(884): MediaWiki->performRequest()
#8 /srv/mediawiki/php-1.34.0-wmf.11/includes/MediaWiki.php(515): MediaWiki->main()
#9 /srv/mediawiki/php-1.34.0-wmf.11/index.php(42): MediaWiki->run()
#10 /srv/mediawiki/w/index.php(3): require(string)
#11 {main}

Impact

Unable to export translatable pages or aggregate groups (not sure if both are affected) for offline translation if PHP 7.2 is used (it's becoming the default in near future).

Notes

From Logstash:

  • Since at least 1.34.0-wmf.8 (25 days ago)
  • From mediawiki.org, wikidata.org, meta.wikimedia.org, commons.wikimedia.org.
  • Does not affect HHVM, only the PHP 7.2 deployments emit the warning.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/Translatemaster+7 -1Fix null warning error thrown by get_class during translation exports
Customize query in gerrit

Event Timeline

Krinkle created this task.Jul 10 2019, 8:43 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 10 2019, 8:43 PM
Nikerabbit added a subscriber: Nikerabbit.Jul 11 2019, 7:55 AM

Is there a way to force PHP7.2 for testing?

Nikerabbit added a project: PHP 7.2 support.Jul 11 2019, 7:57 AM

Note: Explicitly passing NULL as the object is no longer allowed as of PHP 7.2.0.

Nikerabbit moved this task from Backlog to performance and stability on the MediaWiki-extensions-Translate board.Jul 11 2019, 7:57 AM
Nikerabbit updated the task description. (Show Details)
Urbanecm added a subscriber: Urbanecm.Jul 11 2019, 2:25 PM
In T227709#5323528, @Nikerabbit wrote:

Is there a way to force PHP7.2 for testing?

Manually adding a cookie named PHP_ENGINE with value php7 should work.

RazeSoldier moved this task from Untriaged to Wikimedia production on the PHP 7.2 support board.Jul 11 2019, 3:23 PM
Krinkle added a comment.Jul 11 2019, 3:51 PM

@Nikerabbit The WikimediaDebug browser plugin has a PHP 7 checkbox.

Pginer-WMF edited projects, added Language-Team (Language-2019-July-September); removed Language-Team.Jul 16 2019, 7:51 AM
Pginer-WMF moved this task from Backlog to Priority backlog on the Language-Team (Language-2019-July-September) board.
Pginer-WMF triaged this task as Medium priority.Jul 16 2019, 7:58 AM
abi_ added a subscriber: abi_.Jul 16 2019, 8:36 AM
Nikerabbit added a comment.Jul 18 2019, 6:50 AM

The fix should be simple, just check if the group returns null for FFS before comparing the classes.

abi_ claimed this task.Aug 2 2019, 1:51 PM
abi_ moved this task from Priority backlog to In Progress on the Language-Team (Language-2019-July-September) board.
gerritbot added a comment.Aug 7 2019, 9:42 AM

Change 528729 had a related patch set uploaded (by Abijeet Patro; owner: Abijeet Patro):
[mediawiki/extensions/Translate@master] Fix null warning error thrown by get_class during translation exports

https://gerrit.wikimedia.org/r/528729

gerritbot added a project: Patch-For-Review.Aug 7 2019, 9:42 AM
abi_ moved this task from In Progress to In Review on the Language-Team (Language-2019-July-September) board.Aug 7 2019, 10:06 AM
gerritbot added a comment.Aug 17 2019, 10:40 AM

Change 528729 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Fix null warning error thrown by get_class during translation exports

https://gerrit.wikimedia.org/r/528729

Maintenance_bot removed a project: Patch-For-Review.Aug 17 2019, 11:10 AM
abi_ moved this task from In Review to Recheck after deployment on the Language-Team (Language-2019-July-September) board.Aug 18 2019, 7:16 AM
ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.20; 2019-08-27).Aug 20 2019, 10:01 PM
mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:06 PM
Krinkle moved this task from Old to Resolved on the Wikimedia-production-error board.Aug 29 2019, 12:24 AM
Krinkle closed this task as Resolved.Aug 29 2019, 12:30 AM
• Petar.petkovic moved this task from Recheck after deployment to Done on the Language-Team (Language-2019-July-September) board.Aug 29 2019, 6:58 AM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL