Page MenuHomePhabricator
Create Task
Maniphest T227711

BannerHistoryLogger issue prevents users reaching payments wiki
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

During the 1-hour en6C banner test on 2019-07-12, donors were not correctly sent to Payments when they clicked to donate. It seems this was due to an issue with the Banner History Logger never resolving the promise returned by mw.centralNotice.bannerHistoryLogger.ensureLogSent().

Initially, the issue seemed to be a bit different. Here is the previous name and description (in case the issue as originally described shows up again):

bannerHistoryLogger not present when banner history mixin enabled

If the banner history mixin is enabled for a CentralNotice campaign:

  • mw.centralNotice.getDataProperty( 'mixins' ).bannerHistoryLogger is true as expected
  • but mw.centralNotice.bannerHistoryLogger doesn't actually exist
  • since fundraising banners try to use bannerHistoryLogger.ensureLogSent() before submitting to payments, this blocks donors from reaching the payments form.

The last fundraising banners ran in May, so this likely broke since then.

We can probably live without the banner history data for our current tests, and disable the mixin for now. But it should be fixed as this is useful data.

Details

SubjectRepoBranchLines +/-
Banner history logger: remove loading of schema modulemediawiki/extensions/CentralNoticewmf/1.34.0-wmf.16+1 -2
Banner history logger: remove loading of schema modulemediawiki/extensions/CentralNoticewmf/1.34.0-wmf.15+1 -2
Banner history logger: remove loading of schema modulemediawiki/extensions/CentralNoticewmf_deploy+1 -2
Banner history logger: remove loading of schema modulemediawiki/extensions/CentralNoticemaster+1 -2
Customize query in gerrit

Related Objects

Event Timeline

Pcoombe created this task.Jul 10 2019, 9:00 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 10 2019, 9:00 PM
AndyRussG subscribed.Jul 11 2019, 5:46 AM

Hi! I'm getting a different result here...

Looking at the banners via the test campaign on aa.wikibooks...

Indeed, clicking to donate does nothing. However, I am seeing mw.centralNotice.bannerHistoryLogger there as it should be when I look in the console.

Rather, what seems to be happening, at least in my browser (FF 66) is that the promise returned by ensureLogSent() is never resolving. The code that navigates to payments (by setting window.location.href) is in the always() function of that promise. So, that never executes. (See the last bit of frb.submitForm() in CoreJS-2018.js.)

In the console:

> p = mw.centralNotice.bannerHistoryLogger.ensureLogSent();
> p.state()
 "pending"

This is indeed a problem that would not show up when viewing a banner using the on-wiki preview, but that does happen when the banner is shown as part of a campaign. (Here's a task for some improvements in CN that would help avoid this: T227732.)

Following the breadcrumbs, it seems the issue is that [[ https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/CentralNotice/+/master/resources/subscribing/ext.centralNotice.bannerHistoryLogger.js#389 | readyToLogDeferredObj ]] in turn does not resolve, because the promise from [[ https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/CentralNotice/+/master/resources/subscribing/ext.centralNotice.bannerHistoryLogger.js#316 | mw.loader.using() ]] is rejected. Seems like it's due to a change in or related to EventLogging that prevents loading the schema the way we do. In the console:

> mw.loader.using( [ 'schema.' + 'CentralNoticeBannerHistory' ] ).state();
 "rejected"

In any case, as a quick band-aid, turning off banner history should make things work.

Thanks!!!

• DStrine moved this task from Triage to Current Sprint on the Fundraising-Backlog board.Jul 15 2019, 5:17 PM
• DStrine added a project: Fundraising Sprint Never Ending Query.
AndyRussG moved this task from Backlog to Doing on the Fundraising Sprint Never Ending Query board.Jul 16 2019, 6:36 PM
gerritbot added a comment.Jul 17 2019, 6:45 AM

Change 523853 had a related patch set uploaded (by AndyRussG; owner: AndyRussG):
[mediawiki/extensions/CentralNotice@master] Banner history logger: remove loading of schema module

https://gerrit.wikimedia.org/r/523853

gerritbot added a project: Patch-For-Review.Jul 17 2019, 6:45 AM
AndyRussG added a comment.Jul 17 2019, 6:54 AM

I've reproduced the issues I found related this bug both locally on the Beta Cluster, and have a fix that makes it work locally. That is, the patch causes the promise returned by mw.centralNotice.bannerHistoryLogger.ensureLogSent() to resolve properly.

Here is the Beta Cluster test campaign for this.

@Pcoombe can you check if you're still seeing a problem you described in the task, that is, the absence of mw.centralNotice.bannerHistoryLogger, either on the Beta Cluster or via an aa.wikibooks test campaign on production? Maybe that was a different issue?

AndyRussG moved this task from Doing to Review on the Fundraising Sprint Never Ending Query board.Jul 17 2019, 6:54 AM
Pcoombe added a comment.Jul 17 2019, 7:00 PM

No, I can see mw.centralNotice.bannerHistoryLogger on both beta cluster and production now.

AndyRussG added a comment.Jul 17 2019, 7:07 PM
In T227711#5342755, @Pcoombe wrote:

No, I can see mw.centralNotice.bannerHistoryLogger on both beta cluster and production now.

Ah ok thanks... Should I update the task name and description?

The fact that you couldn't see it before might be another issue... Maybe we should just keep an eye out for it happening again, I guess?

Another unkown for me here is why, even with this problem, some donations did come through. I guess they could have been from people who had Do Not Track enabled, though I don't know if that's enough people to account from for the donations we did receive...

Pcoombe added a comment.Jul 17 2019, 7:09 PM
In T227711#5342786, @AndyRussG wrote:
In T227711#5342755, @Pcoombe wrote:

No, I can see mw.centralNotice.bannerHistoryLogger on both beta cluster and production now.

Ah ok thanks... Should I update the task name and description?

Yes please

The fact that you couldn't see it before might be another issue... Maybe we should just keep an eye out for it happening again, I guess?

Another unkown for me here is why, even with this problem, some donations did come through. I guess they could have been from people who had Do Not Track enabled, though I don't know if that's enough people to account from for the donations we did receive...

Yes that puzzled me as well. Something browser dependent maybe?

AndyRussG added a comment.Jul 17 2019, 7:13 PM
In T227711#5342790, @Pcoombe wrote:
In T227711#5342786, @AndyRussG wrote:

Ah ok thanks... Should I update the task name and description?

Yes please

K will do! Thanks :)

The fact that you couldn't see it before might be another issue... Maybe we should just keep an eye out for it happening again, I guess?

Another unkown for me here is why, even with this problem, some donations did come through. I guess they could have been from people who had Do Not Track enabled, though I don't know if that's enough people to account from for the donations we did receive...

Yes that puzzled me as well. Something browser dependent maybe?

The only codepath I see right now where they would have made it through to Payments is when they have Do Not Track enabled... however I may be missing something!

AndyRussG renamed this task from bannerHistoryLogger not present when banner history mixin enabled to BannerHistoryLogger issue prevents users reaching payments wiki.Jul 18 2019, 4:22 AM
AndyRussG updated the task description. (Show Details)
AndyRussG set the point value for this task to 2.
AndyRussG updated the task description. (Show Details)
AndyRussG added a comment.Jul 18 2019, 4:25 AM

Documentation for the change in EventLogging that caused the issue: T205744: Deprecation Information for EventLogging ResourceLoader modules

• DStrine added a project: Fundraising Sprint Office  .Jul 23 2019, 8:29 PM
AndyRussG moved this task from Backlog to Review on the Fundraising Sprint Office   board.Jul 24 2019, 4:50 AM
gerritbot added a comment.Jul 24 2019, 4:25 PM

Change 523853 merged by jenkins-bot:
[mediawiki/extensions/CentralNotice@master] Banner history logger: remove loading of schema module

https://gerrit.wikimedia.org/r/523853

Maintenance_bot removed a project: Patch-For-Review.Jul 24 2019, 5:10 PM
Ejegg moved this task from Review to Pending Deployment on the Fundraising Sprint Office   board.Jul 25 2019, 9:18 PM
gerritbot added a comment.Jul 25 2019, 10:45 PM

Change 525677 had a related patch set uploaded (by AndyRussG; owner: AndyRussG):
[mediawiki/extensions/CentralNotice@wmf_deploy] Banner history logger: remove loading of schema module

https://gerrit.wikimedia.org/r/525677

gerritbot added a project: Patch-For-Review.Jul 25 2019, 10:45 PM
gerritbot added a comment.Jul 25 2019, 10:53 PM

Change 525677 abandoned by AndyRussG:
Banner history logger: remove loading of schema module

https://gerrit.wikimedia.org/r/525677

Maintenance_bot removed a project: Patch-For-Review.Jul 25 2019, 11:10 PM
gerritbot added a comment.Jul 30 2019, 10:44 PM

Change 525677 restored by AndyRussG:
Banner history logger: remove loading of schema module

https://gerrit.wikimedia.org/r/525677

gerritbot added a comment.Jul 30 2019, 10:56 PM

Change 525677 merged by jenkins-bot:
[mediawiki/extensions/CentralNotice@wmf_deploy] Banner history logger: remove loading of schema module

https://gerrit.wikimedia.org/r/525677

gerritbot added a comment.Jul 30 2019, 11:43 PM

Change 526563 had a related patch set uploaded (by Catrope; owner: AndyRussG):
[mediawiki/extensions/CentralNotice@wmf/1.34.0-wmf.16] Banner history logger: remove loading of schema module

https://gerrit.wikimedia.org/r/526563

gerritbot added a project: Patch-For-Review.Jul 30 2019, 11:43 PM
gerritbot added a comment.Jul 30 2019, 11:45 PM

Change 526567 had a related patch set uploaded (by Catrope; owner: AndyRussG):
[mediawiki/extensions/CentralNotice@wmf/1.34.0-wmf.15] Banner history logger: remove loading of schema module

https://gerrit.wikimedia.org/r/526567

gerritbot added a comment.Jul 30 2019, 11:49 PM

Change 526567 merged by jenkins-bot:
[mediawiki/extensions/CentralNotice@wmf/1.34.0-wmf.15] Banner history logger: remove loading of schema module

https://gerrit.wikimedia.org/r/526567

gerritbot added a comment.Jul 30 2019, 11:49 PM

Change 526563 merged by jenkins-bot:
[mediawiki/extensions/CentralNotice@wmf/1.34.0-wmf.16] Banner history logger: remove loading of schema module

https://gerrit.wikimedia.org/r/526563

Stashbot added a comment.Jul 31 2019, 12:01 AM

Mentioned in SAL (#wikimedia-operations) [2019-07-31T00:01:08Z] <catrope@deploy1001> Synchronized php-1.34.0-wmf.16/extensions/CentralNotice/: T227711 among others (duration: 00m 48s)

Stashbot added a comment.Jul 31 2019, 12:04 AM

Mentioned in SAL (#wikimedia-operations) [2019-07-31T00:04:48Z] <catrope@deploy1001> Synchronized php-1.34.0-wmf.15/extensions/CentralNotice/: T227711 among others (duration: 00m 47s)

AndyRussG moved this task from Pending Deployment to Deployed on the Fundraising Sprint Office &nbsp; board.Jul 31 2019, 12:11 AM
Pcoombe closed this task as Resolved.Aug 5 2019, 2:52 PM

Tested a campaign on aa.wikipedia.org with banner history logger enabled, and this looks good now. Thanks @AndyRussG !

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits