Page MenuHomePhabricator

Takedown Tools: Disable the `Child protection` button
Closed, DeclinedPublic0 Estimated Story Points

Description

The "Child protection" button, which switches the takedown tool to handle child protection cases (as opposed to DMCAs) should be disabled in lieu of removing that half of the takedown tools in the future. Per discussions we now solely use NCMEC's CyberTip tool to handle CSE.

Low-priority but this should be a pretty straightforward param change for the tool.

Event Timeline

jrbs triaged this task as Low priority.
jrbs renamed this task from Disable the `Child protection` button on Takedown Tools to Takedown Tools: Disable the `Child protection` button.EditedDec 11 2019, 7:02 PM
jrbs added a subscriber: Niharika.

@Niharika I noticed you removed Anti-Harassment-Team, is that because your team is no longer maintaining this tool? :)

If you point me to the codebase I can probably submit a pull myself

@Niharika I noticed you removed Anti-Harassment-Team, is that because your team is no longer maintaining this tool? :)

If you point me to the codebase I can probably submit a pull myself

No, no. We'll maintain this tool. I took it off because it was marked as low priority so I'd rather keep this task only on the Wikimedia-Takedown-Tools board and not over-populate the already overburdened Anti-Harassment-Team board until we're ready to take it on.
I believe the code is at https://github.com/wikimedia/takedown-tools
If you want us to work on it, let me know and I'll pull it in.

I had a look at this and I'm not sure I can do this (I'm not familiar enough with the language). In particular, I see this line in create.js:

<button type="button" disabled={disabled} style={ { zIndex: 0 } } className={cpButtonClass} onClick={() => this.updateField( 'type', 'cp' )}>Child Protection</button>

I can just switch disabled={disabled} to disabled=true, which would in theory work but I wonder if there's a more efficient / flexible way to do this?

I had a look at this and I'm not sure I can do this (I'm not familiar enough with the language). In particular, I see this line in create.js:

<button type="button" disabled={disabled} style={ { zIndex: 0 } } className={cpButtonClass} onClick={() => this.updateField( 'type', 'cp' )}>Child Protection</button>

I can just switch disabled={disabled} to disabled=true, which would in theory work but I wonder if there's a more efficient / flexible way to do this?

That should unconditionally disable the button, indeed

That should unconditionally disable the button, indeed

cool. I guess I'm just not familiar with the curly braces and where it's pulling the settings from. If there's a settings file in the repo I should modify instead it might make sense to do that instead...

{disabled} is basically a variable. but it's defined on the fly depending on state/status, not in a settings file

		let disabled = this.props.takedown.status === 'saving',
			dmcaButtonClass = 'btn btn-secondary',
			cpButtonClass = 'btn btn-secondary',
			takedownTypeForm,
			metaDataField;

The other option is you can just remove the button completely (and then at a later date someone can remove the code that it uses)

Per recent comments, Wikimedia-Takedown-Tools is not really used anymore, thus declining.