Page MenuHomePhabricator

Never show the unswitchable welcome dialog
Open, Needs TriagePublic

Description

The VE welcome dialog can be shown with two actions or one, depending if switching is currently available:

Switchable:

Un-switchable:

The un-switchable dialog doesn't serve much purpose. It was shown in mobile (until T227670) and is still shown in desktop when VE is not available (e.g. on talk pages).

When no switching is available we should not show the dialog.

Details

Related Gerrit Patches:
mediawiki/extensions/VisualEditor : masterDon't show welcome dialog unless switchable

Event Timeline

Esanders created this task.Jul 11 2019, 1:20 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 11 2019, 1:20 PM

Change 522119 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Don't show welcome dialog unless switchable

https://gerrit.wikimedia.org/r/522119

Does this seem sensible to you @ppelberg ?

Just as a note, it's totally incorrect to imply that the one-action dialog is not as it was designed. We brought the welcome dialog in with only one action based on user testing and feedback about new users feeling abandoned when they clicked 'edit' and immediately entered an editor with no context. We added the switching capability as an after-thought, later.

Of course, it's entirely possible that it's no longer serving product needs given changes in expectation, environment, and/or design, or that user focus priority is elsewhere, or product focus has moved to supporting other use cases, but please be up-front. :-)

Esanders added a comment.EditedJul 11 2019, 5:12 PM

Just as a note, it's totally incorrect to imply that the one-action dialog is not as it was designed.

I didn't intend to imply that. We've just been discussing it and feel that it doesn't help with the experience.

Ping @ppelberg. This is one of the cases we discussed yesterday: hiding the welcome dialog when no switch at all is offered.

Thanks for the ping, @Esanders.

As this relates to yesterday's conversation RE T189569, I understood us as having gotten to a place where we decided to remove the "switchable" welcome dialog on wikis where VE is already the default.

I don't remember us talking about what we do with the un-switchable welcome dialog on desktop. Tho, I realize this could've been implicit and also a natural extension of T227670.

Regardless, I'm starting to feel uncomfortable about making too many changes to the newcomer experience without first knowing:
a) The range of prompts that are currently live
b) How these "prompts" are affecting contributors

So most immediately, a resulting question for you: can we remove the "switchable" welcome dialog on wikis where VE is already the default without – at this moment – changing how the "unswitchable" welcome dialog behaves?

So most immediately, a resulting question for you: can we remove the "switchable" welcome dialog on wikis where VE is already the default without – at this moment – changing how the "unswitchable" welcome dialog behaves?

Yes - the current patch *only* removes the un-switchable dialog, so there would be a separate patch to remove the dialog when VE is not the default.

I would note that this is likely to be the less controversial of the two patches, as (1) the single button dialog doesn't provide any actual functionality and (2) it only shows when your first edit is to a namespace where VE isn't available (e.g. talk pages) so is more of an edge case.