Page MenuHomePhabricator

mw-echo-ui-datedSubGroupListWidget-title-primary should not have display: inline-block. It breaks non-latin texts
Open, Needs TriagePublic

Description

Right now, echo in Persian Wikipedia gives me titles that are wrong for weekday.


while it should be:

Technically, they are the same text but first letter got a non-joined form which it should not.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
kostajh added a subscriber: kostajh.

We will try to get to this in Q2, but patches submitted by others before then are welcome!

@Ladsgroup @kostajh Could one of you help update the task description by adding clear steps to reproduce broken titles, and some getting started instructions that might help a new contributor landing on this task (as it has the good first task tag)?

This still happens, you need to have some notification in your system and then set your language to Persian.
The weekday should be something like this:


(This is for "Wednesday")

if you remove display: inline-block from the .mw-body-content .mw-echo-ui-datedSubGroupListWidget-title-primary CSS selector, it would fix it but I'm not sure if it's okay to just drop it.

@Ladsgroup can u temme how to get started with this? and where can i find the source code?

can u temme how to get started with this? and where can i find the source code?

@Vaibhav_apt: Please see the blue "Tags" on this task for hints about the code repository. In this case, it's in mediawiki/extensions/echo in Gerrit. :)

Restricted Application added a subscriber: Huji. · View Herald TranscriptThu, Apr 15, 6:51 PM