Page MenuHomePhabricator

Don’t check constraints on “Wikidata property example for media” statements
Closed, ResolvedPublic

Description

As an editor, I don’t want to see useless constraint violations.

Problem:
On Wikidata property example statements, we skip constraint checks since the results aren’t useful (see T183267). However, we don’t yet do the same on Wikidata property example for media statements, so you see bogus violations on e. g. Property:P6731#P6685.

Example/Screenshots:

Screenshot_2019-07-12 Commons quality assessment.png (465×920 px, 187 KB)

(The image shown is © Guillaume Piolle / CC BY 3.0, Aix-en-Provence - Pavillon Vendôme, CC BY 3.0.)

BDD
GIVEN I am logged in
WHEN I look at a Wikidata property example for media statement
THEN I see no constraint violations.

Acceptance criteria:

  • P6685 is part of wgWBQualityConstraintsPropertiesWithViolatingQualifiers in operations/mediawiki-config.git
  • P6685 is not part of the default WikibaseQualityConstraints config – we don’t need this property automatically imported on every other wiki with WikibaseQualityConstraints

Open questions:

  • Any other missing properties? See the current list of properties – any other “property example”-type properties not in there should be added too.

Event Timeline

I checked all of properties and the only one that has the word "example" in it and it's not there (plus the one mentioned here) is https://www.wikidata.org/wiki/Property:P5831 which actually should not be in the list so I think we are good here.

Change 562083 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[operations/mediawiki-config@master] Don’t check constraints on P6685 statements

https://gerrit.wikimedia.org/r/562083

Change 562083 merged by jenkins-bot:
[operations/mediawiki-config@master] Don’t check constraints on P6685 statements

https://gerrit.wikimedia.org/r/562083

Mentioned in SAL (#wikimedia-operations) [2020-01-06T12:18:41Z] <ladsgroup@deploy1001> Synchronized wmf-config/InitialiseSettings.php: SWAT: [[gerrit:562083|Don’t check constraints on P6685 statements (T227865)]] (duration: 00m 55s)

Fixed, no more violations on the sample page given in the task description (after purging).