Page MenuHomePhabricator
Create Task
Maniphest T227916

Echo notification icons vanish before the mobile cutoff when resizing a window
Closed, ResolvedPublic
Actions

Description

Echo notification icons vanish before the mobile cutoff when resizing a window when the page has a scrollbar.

Additionally, if the user clicks one of the notification icons, then resizes the browser to a mobile width, and then resizes it back, they become duplicated.

Details

ProjectBranchLines +/-Subject
mediawiki/skins/MonoBookmaster+10 -10Use media queries rather than manual checks for mobile hacks
mediawiki/skins/MonoBookmaster+12 -5Fix funny Echo integration when mobile hack kicks in after using the icons
Customize query in gerrit

Related Objects

Event Timeline

matmarex created this task.Jul 12 2019, 7:56 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 12 2019, 7:56 PM
matmarex mentioned this in T226875: monobook skin "your alerts" click brings "your notices".EditedJul 12 2019, 7:56 PM
matmarex added a subscriber: Schnark.

(Split off from T226875:)

In T226875#5295649, @Schnark wrote:

…

Slowly decrease the width of the window and observe all the weirdness that happens:

…

At 560px, the two Echo icons suddenly vanish.

At 550px, the responsive layout appears, where the two Echo icons overlap the user icon, and are unclickable.

gerritbot added a comment.Jul 12 2019, 7:59 PM

Change 522546 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/skins/MonoBook@master] Fix funny Echo integration when mobile hack kicks in after using the icons

https://gerrit.wikimedia.org/r/522546

gerritbot added a project: Patch-For-Review.Jul 12 2019, 7:59 PM

Change 522547 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/skins/MonoBook@master] Use media queries rather than manual checks for mobile hacks

https://gerrit.wikimedia.org/r/522547

gerritbot added a comment.Jul 12 2019, 8:54 PM

Change 522546 merged by jenkins-bot:
[mediawiki/skins/MonoBook@master] Fix funny Echo integration when mobile hack kicks in after using the icons

https://gerrit.wikimedia.org/r/522546

gerritbot added a comment.Jul 12 2019, 8:54 PM

Change 522547 merged by jenkins-bot:
[mediawiki/skins/MonoBook@master] Use media queries rather than manual checks for mobile hacks

https://gerrit.wikimedia.org/r/522547

Gerrit Code Review <gerrit@wikimedia.org> mentioned this in rSKIN3bb1223fdc2a: Update git submodules.Jul 12 2019, 8:54 PM
Gerrit Code Review <gerrit@wikimedia.org> mentioned this in rSKIN66f56898898c: Update git submodules.
matmarex mentioned this in rSMNB3f52a1796cd0: Fix funny Echo integration when mobile hack kicks in after using the icons.Jul 12 2019, 8:56 PM
matmarex mentioned this in rSMNB6c53b601f8df: Use media queries rather than manual checks for mobile hacks.
ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.14; 2019-07-16).Jul 12 2019, 9:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 12 2019, 9:10 PM
matmarex closed this task as Resolved.Jul 15 2019, 5:49 PM
matmarex claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL