Page MenuHomePhabricator
Create Task
Maniphest T227929

CSS spiked by 2kb (23% increase) for ALL users
Closed, ResolvedPublic
Actions

Description

Despite no major releases, CSS on all page views jumped from 7.3kb to 9kb with a change that went live on the beta cluster on 7/7 and live in production today.

Graph: https://grafana.wikimedia.org/d/000000205/mobile-2g?panelId=69&fullscreen&orgId=1

Screenshot 2019-07-12 at 5.15.12 PM.png (621×1 px, 44 KB)

https://gerrit.wikimedia.org/r/#/c/mediawiki/skins/MinervaNeue/+/518114/ looks like the most likely cause.

While the 2kb may be justified, it should not have been shipped into a production un-feature flagged setting and we should look to mediate that.

Details

ProjectBranchLines +/-Subject
mediawiki/skins/MinervaNeuewmf/1.34.0-wmf.14+4 -1Do not load main menu icons in critical path
mediawiki/skins/MinervaNeuewmf/1.34.0-wmf.13+4 -1Do not load main menu icons in critical path
mediawiki/skins/MinervaNeuemaster+4 -1Do not load main menu icons in critical path
mediawiki/skins/MinervaNeuewmf/1.34.0-wmf.13+5 -8Restrict AMC scripts and styles to AMC mode
mediawiki/skins/MinervaNeuemaster+5 -8Restrict AMC scripts and styles to AMC mode
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Jul 13 2019, 12:19 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 13 2019, 12:19 AM
Jdlrobson triaged this task as Unbreak Now! priority.Jul 13 2019, 12:19 AM
Restricted Application added a subscriber: Liuxinyu970226. · View Herald TranscriptJul 13 2019, 12:19 AM
Jdlrobson renamed this task from CSS spiked by 2kb for ALL users to CSS spiked by 2kb (23% increase) for ALL users.Jul 13 2019, 12:21 AM
Jdlrobson added a project: Performance Issue.
Jdlrobson added a comment.Jul 13 2019, 12:24 AM

Related: T227908

Jdlrobson added a subscriber: Krinkle.Jul 13 2019, 12:24 AM
gerritbot added a comment.Jul 13 2019, 12:34 AM

Change 522577 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Restrict AMC scripts and styles to AMC mode

https://gerrit.wikimedia.org/r/522577

gerritbot added a project: Patch-For-Review.Jul 13 2019, 12:34 AM
Krinkle edited projects, added Performance-Team (Radar); removed Performance Issue.Jul 13 2019, 5:23 PM

Thanks, let's hope this'll resolve T227908 as well.

Krinkle moved this task from Limbo to Watching on the Performance-Team (Radar) board.Jul 13 2019, 5:23 PM
Jdlrobson moved this task from Needs Analysis to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.Jul 15 2019, 4:49 PM
gerritbot added a comment.Jul 15 2019, 6:53 PM

Change 523260 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@wmf/1.34.0-wmf.13] Restrict AMC scripts and styles to AMC mode

https://gerrit.wikimedia.org/r/523260

gerritbot added a comment.Jul 15 2019, 7:50 PM

Change 522577 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Restrict AMC scripts and styles to AMC mode

https://gerrit.wikimedia.org/r/522577

Gerrit Code Review <gerrit@wikimedia.org> mentioned this in rSKIN6de329717e85: Update git submodules.Jul 15 2019, 7:52 PM
Jdlrobson moved this task from Needs Code Review to Blocked on Others on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.Jul 15 2019, 7:53 PM
ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.14; 2019-07-16).Jul 15 2019, 8:01 PM
gerritbot added a comment.Jul 16 2019, 12:00 AM

Change 523260 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@wmf/1.34.0-wmf.13] Restrict AMC scripts and styles to AMC mode

https://gerrit.wikimedia.org/r/523260

Stashbot added a comment.Jul 16 2019, 12:05 AM

Mentioned in SAL (#wikimedia-operations) [2019-07-16T00:05:18Z] <catrope@deploy1001> Synchronized php-1.34.0-wmf.13/skins/MinervaNeue/: Restrict AMC scripts and styles to AMC mode (T227929) (duration: 00m 52s)

Maintenance_bot removed a project: Patch-For-Review.Jul 16 2019, 12:10 AM
Jdlrobson moved this task from Blocked on Others to Ready for Signoff on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.Jul 16 2019, 12:11 AM
ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.13; 2019-07-09); removed MW-1.34-notes (1.34.0-wmf.14; 2019-07-16).Jul 16 2019, 1:00 AM
gerritbot added a comment.Jul 16 2019, 5:00 PM

Change 523774 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Do not load main menu icons in critical path

https://gerrit.wikimedia.org/r/523774

gerritbot added a project: Patch-For-Review.Jul 16 2019, 5:00 PM
Jdlrobson moved this task from Ready for Signoff to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.Jul 16 2019, 5:02 PM
gerritbot added a comment.Jul 16 2019, 5:27 PM

Change 523780 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@wmf/1.34.0-wmf.13] Do not load main menu icons in critical path

https://gerrit.wikimedia.org/r/523780

gerritbot added a comment.Jul 16 2019, 5:28 PM

Change 523781 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@wmf/1.34.0-wmf.14] Do not load main menu icons in critical path

https://gerrit.wikimedia.org/r/523781

Jdlrobson moved this task from Needs Code Review to Blocked on Others on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.Jul 16 2019, 5:28 PM
gerritbot added a comment.Jul 16 2019, 7:40 PM

Change 523774 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Do not load main menu icons in critical path

https://gerrit.wikimedia.org/r/523774

Gerrit Code Review <gerrit@wikimedia.org> mentioned this in rSKIN5165ded73284: Update git submodules.Jul 16 2019, 7:44 PM
ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.15; 2019-07-23); removed MW-1.34-notes (1.34.0-wmf.13; 2019-07-09).Jul 16 2019, 8:00 PM
gerritbot added a comment.Jul 16 2019, 11:16 PM

Change 523780 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@wmf/1.34.0-wmf.13] Do not load main menu icons in critical path

https://gerrit.wikimedia.org/r/523780

gerritbot added a comment.Jul 16 2019, 11:17 PM

Change 523781 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@wmf/1.34.0-wmf.14] Do not load main menu icons in critical path

https://gerrit.wikimedia.org/r/523781

Stashbot added a comment.Jul 16 2019, 11:26 PM

Mentioned in SAL (#wikimedia-operations) [2019-07-16T23:26:54Z] <catrope@deploy1001> Synchronized php-1.34.0-wmf.13/skins/MinervaNeue/: Do not load main menu icons in critical path (T227929) (duration: 00m 56s)

Stashbot added a comment.Jul 16 2019, 11:27 PM

Mentioned in SAL (#wikimedia-operations) [2019-07-16T23:27:49Z] <catrope@deploy1001> Synchronized php-1.34.0-wmf.14/skins/MinervaNeue/: Do not load main menu icons in critical path (T227929) (duration: 00m 55s)

Jdlrobson moved this task from Blocked on Others to Ready for Signoff on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.Jul 16 2019, 11:41 PM
ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.13; 2019-07-09); removed MW-1.34-notes (1.34.0-wmf.15; 2019-07-23).Jul 17 2019, 12:00 AM
Maintenance_bot removed a project: Patch-For-Review.Jul 17 2019, 12:10 AM
Jdlrobson lowered the priority of this task from Unbreak Now! to High.Jul 17 2019, 5:10 PM

CSS is now back to normal. Will check other graphs.

Jdlrobson claimed this task.Jul 17 2019, 5:10 PM
Jdlrobson closed this task as Resolved.Jul 19 2019, 4:40 PM
Jdlrobson mentioned this in T227908: Investigate 2019-07-11 page load time regression on mobile (1.34-wmf.13).Jul 19 2019, 4:44 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL