Page MenuHomePhabricator

Autocomplete SPARQL variables names inside BMP
Closed, ResolvedPublic

Description

In Query Service typing a variable name outside of [a-zA-Z0-9_] results in no syntactic coloration and no autocomplete, although the SPARQL specification is quite extension about variable names and Blazegraph accepts any variable name inside the Unicode BMP (Basic Multilingual Plane). Example.

I proposed – and it was accepted – to CodeMirror to extend syntactic coloration to any SPARQL variable inside BMP, see PR #5935. It should appear from version 5.49.0+ of CodeMirror.

I propose in this task a patch to enable autocomplete for any variable name inside BMP.

PS: according to some tests, Blazegraph and/or another piece in the Query Service does not accept variables names outside BMP; for instance try with 𠇲 (U+U+201F2 CJK UNIFIED IDEOGRAPH-201F2), so this task limits itself to BMP. Another task should be opened for astral planes (above BMP).

Event Timeline

Seb35 created this task.Jul 13 2019, 3:36 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 13 2019, 3:36 PM
Restricted Application added a project: Wikidata. · View Herald TranscriptJul 13 2019, 3:36 PM
Seb35 triaged this task as Low priority.Jul 13 2019, 3:37 PM

Change 522599 had a related patch set uploaded (by Seb35; owner: Seb35):
[wikidata/query/gui@master] Hint for permissible SPARQL variables inside BMP

https://gerrit.wikimedia.org/r/522599

Adding to the campsite review board because it’s just been sitting around on Gerrit for ages (and I don’t want to merge it myself after having significantly updated the change).

Change 522599 merged by jenkins-bot:
[wikidata/query/gui@master] Hint for permissible SPARQL variables inside BMP

https://gerrit.wikimedia.org/r/522599

Change 593520 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[wikidata/query/gui-deploy@production] Merging from 5546deb8f12e0b3ef2d6f5dbfb28e76f15a92fd7:

https://gerrit.wikimedia.org/r/593520

Change 594442 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[wikidata/query/gui-deploy@production] Merging from 8aded016c8b9d376c7defbbb33684cd57b50c604:

https://gerrit.wikimedia.org/r/594442

Change 593520 abandoned by Lucas Werkmeister (WMDE):
Merging from 5546deb8f12e0b3ef2d6f5dbfb28e76f15a92fd7:

Reason:
Superseded by Id1fe3fce30.

https://gerrit.wikimedia.org/r/593520

Change 594442 merged by Gehel:
[wikidata/query/gui-deploy@production] Merging from 8aded016c8b9d376c7defbbb33684cd57b50c604:

https://gerrit.wikimedia.org/r/594442

Lucas_Werkmeister_WMDE closed this task as Resolved.Fri, May 15, 4:20 PM

This was deployed last week and is working now (example).