Page MenuHomePhabricator

Gerrit doesn't include CR comment set if you add hashtags in the same push
Open, Needs TriagePublic0 Estimate Story Points

Description

In https://gerrit.wikimedia.org/r/c/mediawiki/extensions/AbuseFilter/+/522649 libup is pushing using a command like git push origin HEAD:refs/for/master%topic=bump-dev-deps,t=CVE-2019-10746,l=Code-Review+2

However, in the first patchset comment, you only see "Hashtags added..."

Compare this to a pre-hashtag patch like https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Scribunto/+/516204 where it said "Uploaded patch set 1: Code-Review+2.".

Event Timeline

Legoktm created this task.Jul 14 2019, 7:41 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 14 2019, 7:41 AM

If you try and add a comment while pushing using https://gerrit.wikimedia.org/r/Documentation/user-upload.html#message the hashtag comment will also overwrite that one - see https://gerrit.wikimedia.org/r/c/mediawiki/extensions/TemplateWizard/+/564832

@Paladox do you think you could report this upstream (if it hasn't been already)?

Legoktm moved this task from Backlog to Reported Upstream on the Upstream board.Thu, Jan 16, 8:21 PM