Page MenuHomePhabricator

PluggableAuthLogin fails SpecialPageFatalTest::testSpecialPageDoesNotFatal
Closed, ResolvedPublic0 Estimated Story Points

Description

Seen in the test failures for LDAPAuthorization:

09:02:20 1) SpecialPageFatalTest::testSpecialPageDoesNotFatal with data set "PluggableAuthLogin" (PluggableAuthLogin Object (...))
09:02:20 === Logs generated by test case
09:02:20 [wfDebug] [debug] IP: 127.0.0.1 {"private":false}
09:02:20 [PluggableAuth] [info] In execute() {"private":false}
09:02:20 [PluggableAuth] [info] Getting PluggableAuth singleton {"private":false}
09:02:20 ===
09:02:20 Undefined index: wgPluggableAuth_Class
09:02:20 
09:02:20 /workspace/src/extensions/PluggableAuth/includes/PluggableAuth.php:40
09:02:20 /workspace/src/extensions/PluggableAuth/includes/PluggableAuthLogin.php:27
09:02:20 /workspace/src/tests/phpunit/includes/specials/SpecialPageExecutor.php:108
09:02:20 /workspace/src/tests/phpunit/includes/specials/SpecialPageExecutor.php:36
09:02:20 /workspace/src/tests/phpunit/structure/SpecialPageFatalTest.php:33
09:02:20 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:453
09:02:20 /workspace/src/maintenance/doMaintenance.php:99

https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php72-docker/14234/console

Event Timeline

LDAPAuthorization (an authorization plugin) requires PluggableAuth. PluggableAuth requires a single authentication plugin (e.g. LDAPAuthentication2 or others). One solution would be to use a dummy authentication plugin for testing, but that should NOT be loaded in production. Would this be a good use case for T196090?

Maybe. The problem is that $wgPluggableAuth_Class has no default value and can't just run out of the box. Having a dummy plugin that just works sounds like a good idea.

cicalese triaged this task as Medium priority.Apr 12 2020, 10:28 PM
cicalese moved this task from Backlog to Issue on the User-Cicalese board.
cicalese moved this task from Backlog to Closed on the MediaWiki-extensions-Pluggable-Auth board.
cicalese removed a project: User-Cicalese.