Page MenuHomePhabricator

Align MinervaNeue/MobileFrontend visual message treatment to Style Guide
Open, Needs TriagePublic

Description

Bring MinervaNeue & MobileFrontend error/warning/success messages/message box visual appearance close to Style Guide components template.

Originated in T127405 with current treatment is off template and has too low contrast accessibility issues

Proposed unified colors

Steps to accomplish

  • Both, MinervaNeue & MobileFrontend are currently importing mediawiki.ui variables and define their own. Let's remove special overrides and just references mediawiki.ui vars until MN/MF gets independent from it. Defining in 3 places makes 0 sense
  • Align only colors and borders for now, padding seems contextual. Can revisit in a box unification at a later point

Details

Related Gerrit Patches:
mediawiki/skins/MinervaNeue : masterReplace special message variables with mediawiki.ui ones
mediawiki/extensions/MobileFrontend : masterRemove special message variables and unify message appearance

Event Timeline

Restricted Application added a project: UI-Standardization. · View Herald TranscriptJul 15 2019, 10:14 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Volker_E renamed this task from Align MinervaNeue visual message treatment to Style Guide to Align MinervaNeue/MobileFrontend visual message treatment to Style Guide.Jul 15 2019, 12:14 PM
Volker_E updated the task description. (Show Details)Jul 15 2019, 12:17 PM

Change 523155 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/skins/MinervaNeue@master] Replace special message variables with mediawiki.ui ones

https://gerrit.wikimedia.org/r/523155

Volker_E updated the task description. (Show Details)
Volker_E added a subscriber: Jdrewniak.
Volker_E added a subscriber: ovasileva.

We need clarification on a current, non-standard special treatment on MobileFrontend.
Both, errorbox and error styles receive a boxed appearance.
We should differentiate boxed and inline messages, as established in the Style Guide. That means, we need to ensure all instances of boxed error should be changed to errorbox when needed. @Jdlrobson your thoughts?

Change 523159 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/extensions/MobileFrontend@master] Remove special message variables and unify message appearance

https://gerrit.wikimedia.org/r/523159

Change 523159 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Remove special message variables and unify message appearance

https://gerrit.wikimedia.org/r/523159

Thanks @Jdlrobson for reviewing quickly. One derived task has already been identified in T228100: Errors in mobile editor preview appear unstyled and are not obviously errors.

Another follow-up would be to re-consider specific .error treatment in https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/MobileFrontend/+/refs/heads/master/resources/mobile.talk.overlays/talk.less#6

Class is currently on a textarea, it doesn't seem to get applied even when error is set:


Also, that should probably be generalized on mw-ui-input and not as talk.less specific rule?
URL of my example above: https://en.m.wikipedia.org/wiki/Talk:National_Museum,_New_Delhi#/talk/new

Change 523155 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Replace special message variables with mediawiki.ui ones

https://gerrit.wikimedia.org/r/523155

This comment was removed by Jdlrobson.