Page MenuHomePhabricator

Remove Image-reviewer group from extension.json
Closed, ResolvedPublic

Description

The group name is (when left in default settings) misleading. A group with only mass-upload right can be called Mass uploaders, but certainly not Image reviewers - mass uploding has no relevance with image reviewing.

In addition, some wikis might want to not have image reviewers having mass-upload right. As such, I propose removing this group from extension.json.

Details

Related Gerrit Patches:
mediawiki/extensions/UploadWizard : wmf/1.34.0-wmf.13Remove Image-reviewer group from extension.json
mediawiki/extensions/UploadWizard : masterRemove Image-reviewer group from extension.json

Event Timeline

Urbanecm created this task.Jul 15 2019, 3:48 PM
Restricted Application added a project: Multimedia. · View Herald TranscriptJul 15 2019, 3:48 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 523208 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[mediawiki/extensions/UploadWizard@master] Remove Image-reviewer group from extension.json

https://gerrit.wikimedia.org/r/523208

Agreed. This Image-reviewers group seems very Wikimedia-specific to be defined in the extension's code. I suggest to drop it from the extension code and let wikis use LocalSettings.php to define additional user groups as needed.

Do you think this needs to be announced somewhere, as a (potentionally) breaking change?

I'll also note that this was added in https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/UploadWizard/+/bfdb1ab697fecf2a1b184128c387bcdd9bce4a83%5E%21/extension.json to solely increase the upload limits for certain user groups. This is not a user right that the extension needs apparently, and the mass-upload permission can simply be assigned to commonswiki image-reviewers via InitialiseSettings.php IMHO.

This is not a user right that the extension needs apparently, and the mass-upload permission can simply be assigned to commonswiki image-reviewers via InitialiseSettings.php IMHO.

Sure, that's already done with https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/523143 btw.

Change 523214 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[operations/mediawiki-config@master] Revert "Delete Image-reviewer group from commonswiki for good"

https://gerrit.wikimedia.org/r/523214

Steinsplitter added a subscriber: Steinsplitter.EditedJul 15 2019, 4:04 PM

(accidentally deleted)

This is for https://commons.wikimedia.org/wiki/Commons:License_review and the local abusefilter.

@Steinsplitter This task isn't about _deleting_ this group from our wikis. This is just about removing the group from extension.json (=stuff defined there is applied on all wikis that make use of UploadWizard, unless they override it in LocalSettings.php), in favour of redefining this in Wikimedia wikis configuration. The redefining has been already done for commons btw, since the group is now called image-reviewer internally, while it was Image-reviewer previously. There will be no change for Commons, and filter 70 will work just as it works now.

@Steinsplitter This task isn't about _deleting_ this group from our wikis. This is just about removing the group from extension.json (=stuff defined there is applied on all wikis that make use of UploadWizard, unless they override it in LocalSettings.php), in favour of redefining this in Wikimedia wikis configuration. The redefining has been already done for commons btw, since the group is now called image-reviewer internally, while it was Image-reviewer previously. There will be no change for Commons, and filter 70 will work just as it works now.

Perfect! Thank you 😄

Change 523208 merged by jenkins-bot:
[mediawiki/extensions/UploadWizard@master] Remove Image-reviewer group from extension.json

https://gerrit.wikimedia.org/r/523208

matmarex closed this task as Resolved.Jul 15 2019, 7:06 PM
matmarex assigned this task to Urbanecm.
Restricted Application added a project: User-Urbanecm. · View Herald TranscriptJul 15 2019, 7:06 PM

Change 523289 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[mediawiki/extensions/UploadWizard@wmf/1.34.0-wmf.13] Remove Image-reviewer group from extension.json

https://gerrit.wikimedia.org/r/523289

Change 523289 abandoned by Urbanecm:
Remove Image-reviewer group from extension.json

Reason:
let's wait for train

https://gerrit.wikimedia.org/r/523289