Page MenuHomePhabricator

Support posting screenshots in Gerrit
Closed, DeclinedPublicFeature

Description

It would be really nice to be able to post screenshots in code review comments in Gerrit.

This issue in Gerrit links to this plugin, maybe we could test it?

Event Timeline

kostajh changed the subtype of this task from "Task" to "Feature Request".Jul 15 2019, 5:59 PM

That extension does not appear to support PolyGerrit.

Aklapper raised the priority of this task from Medium to Needs Triage.Jul 16 2019, 12:24 PM

I don't see how/why this has been prioritized hence resetting

I don't see how/why this has been prioritized hence resetting

@Aklapper looks like the "Create task" form defaults to "Normal" for priority; should this be changed to Needs Triage?

hashar triaged this task as Medium priority.Jul 17 2019, 7:13 AM
hashar moved this task from Bugs & stuff to Needs a plugin! on the Gerrit board.
hashar added a project: Upstream.

[OT] @kostajh: Thanks for catching that! Fixed.

That extension does not appear to support PolyGerrit.

That's unfortunate. @Paladox are you aware of any alternatives?

Where would these be hosted? I worry about having Gerrit carry this additional non-trivial hosting responsibility.

I do agree very much with the desired end result of being able to input and render an image in context of code review. Perhaps a bridge to Phabricator would make sense here. E.g. it would authenticate and upload through its API. Then through a Gerrit plugin for comment syntax (as we do for several things already like task numbers) we could have urls like "https://phabricator.wikimedia.org/F###" result in a thumbnail.

You can either configure the inbuilt image server or use an external one, see https://gerrit.googlesource.com/plugins/imagare/+/refs/heads/master/src/main/resources/Documentation/about.md

Note the plugin is marked as deprecated / unmaintained https://gerrit.googlesource.com/plugins/imagare/+/refs/heads/master/README.md I have asked the commit author whether they have a replacement.

I have asked the upstream authors and the plugin is indeed legacy. It would need a complete rewrite of the UI part and probably some addition to Gerrit UI itself. It was not wide spread used by them and they have choose to discontinue it.