Page MenuHomePhabricator

Have libup rename .eslintrc to .eslintrc.json
Closed, ResolvedPublic0 Estimate Story Points


.eslintrc (if they exist) files should automatically be renamed to .eslintrc.json.

See for an example patch that implemented a different kind of fixer. You likely want to use the shutil.move function to implement this.



Related Gerrit Patches:

Event Timeline

Legoktm triaged this task as Lowest priority.Jul 15 2019, 10:50 PM
Legoktm created this task.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 15 2019, 10:50 PM

Hi @Legoktm ,
it's .eslintrc files under libraryupgrader, right?


Hi @Legoktm ,
it's .eslintrc files under libraryupgrader, right?

hi! libraryupgrader clones *other* git repositories and applies some fixes to them. We want libraryupgrader to automatically rename .eslintrc files if they exist. The related patch I linked might help as well.

Mh-3110 added a comment.EditedJul 17 2019, 5:32 AM

Thank you @Legoktm .
I will work on this.

Mh-3110 claimed this task.Jul 17 2019, 5:33 AM

@Mh-3110 any progress so far? Let me know if you need any help/assistance or have questions.

@Legoktm ,
It is clear what needs to be done here. Will submit the patch this week-end the latest.

Will let you know if I need any assistance.

Thank you

Legoktm removed Mh-3110 as the assignee of this task.Fri, Jan 10, 2:10 AM

@Mh-3110 I'm unassigning this from you since you haven't made any progress - feel free to reassign if you're ready to work on it again.

Legoktm updated the task description. (Show Details)Fri, Jan 10, 5:39 AM

Change 563467 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[labs/libraryupgrader@master] Use json file extension for the config files

Change 563467 merged by jenkins-bot:
[labs/libraryupgrader@master] Use json file extension for the config files

Legoktm closed this task as Resolved.Wed, Jan 15, 1:26 AM
Legoktm assigned this task to Umherirrender.