Page MenuHomePhabricator
Create Task
Maniphest T228216

Trying to open VE while the toast message is open shows an overlapping view of Read mode and edit mode
Closed, ResolvedPublic
Actions

Description

Steps to replicate:

  1. Go to this page: https://en.m.wikipedia.org/wiki/User:RYasmeen_(WMF)/sandbox.
  2. Tap on a reference note.
  3. Now when the toast menu appears, click on a section edit link.

    Observe that, you are now in a mode which seems like an overlap of Read mode and Edit mode.

IMG_3546.jpg (1×640 px, 74 KB)

Related Objects
Search...

Event Timeline

Ryasmeen created this task.Jul 16 2019, 8:46 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 16 2019, 8:46 PM
Ryasmeen renamed this task from Trying to open VE while the toast is open shows an overlapping view of Read mode and edit mode to Trying to open VE while the toast message is open shows an overlapping view of Read mode and edit mode.Jul 16 2019, 11:30 PM
matmarex claimed this task.Jul 17 2019, 5:18 PM
matmarex subscribed.

Freaky.

Can't tell how this visual issue happens, but I can tell that the edit pencil shouldn't be clickable while the reference toast is open. Tapping anywhere should only close the toast.

matmarex added a comment.Jul 17 2019, 9:31 PM

There's a MobileFrontend task about drawers (e.g. the reference thing) that actually calls out this exact behavior: T214049

matmarex added a subtask: T214049: Technical: Every Drawer has a shield for catching clicks.Jul 17 2019, 9:31 PM
matmarex mentioned this in T214049: Technical: Every Drawer has a shield for catching clicks.Jul 17 2019, 9:37 PM
matmarex edited projects, added VisualEditor (Current work); removed VisualEditor.
matmarex moved this task from Incoming to Code review on the VisualEditor (Current work) board.

Patches at T214049#5343482, hoping for review from the Reading team.

matmarex moved this task from Code review to QA on the VisualEditor (Current work) board.Jul 18 2019, 12:27 AM

That was quick :o

Ryasmeen added a project: Verified.Jul 23 2019, 9:33 PM
Ryasmeen moved this task from QA to Product owner review on the VisualEditor (Current work) board.
• ppelberg closed this task as Resolved.Aug 6 2019, 2:52 AM
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptAug 6 2019, 2:52 AM
Jdlrobson closed subtask T214049: Technical: Every Drawer has a shield for catching clicks as Resolved.Jan 14 2020, 7:40 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL