For a message to be sent, a target list, a subject, and a message all must be specified. When clicking "preview", if the requirements aren't met yet, the information relating to actually sending the message shouldn't be displayed, because it is not yet ready to be sent.
Once this view is displayed, a user can add a subject, message, and target list and then send the message without ever previewing it. The preview shouldn't be shown until the message can actually be sent.
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | BUG REPORT | None | T290035 Edits to the page sent as a message before a mass message job finishes causes content sent to also change | ||
| Open | BUG REPORT | None | T228218 Special:MassMessage shows "send" button and copyright notice even when message can't be sent |
This ideally will be needed to be fixed for implementation of T290035 as Special:MassMessage will need to keep track of a valid revision ID that is shown in a preview that was ready to send. Without fixing this, the user could submit a form with errors for preview, then fix them while changing the page message to a new title and then press send with the page title and revision ID being from different places. The user following these steps would then be presented with an error caused by an action they didn't directly follow. Furthermore, in this scenario the preview won't show what was going to be sent.
Change 868847 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):
[mediawiki/extensions/MassMessage@master] Don't show the preview unless the form data submitted has no errors
Without fixing this, the user could submit a form with errors for preview, then fix them while changing the page message to a new title and then press send with the page title and revision ID being from different places.
Note that to some extent we can't fix this completely without forcing users to preview again if they make any changes (which I don't think we should), since they can always make changes to a valid request on preview, and make it invalid again.
Change 872487 had a related patch set uploaded (by Wctaiwan; author: Wctaiwan):
[mediawiki/extensions/MassMessage@master] Hide submit button if form data has errors
Change 868847 abandoned by Dreamy Jazz:
[mediawiki/extensions/MassMessage@master] Don't show the preview unless the form data submitted has no errors
Reason:
In favour of I4c20b9b6750e0a1614ee04d1d7ae03140c5524bc
Change 872487 merged by jenkins-bot:
[mediawiki/extensions/MassMessage@master] Hide submit button if form data has errors