Edits lost when clicking back from talk overlay
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To

Authored By

	Jdlrobson
	Jul 16 2019, 11:33 PM

Description

NOTE: Discovered while working on T226106

Visit https://en.m.wikipedia.beta.wmflabs.org/wiki/Spain#/talk/new
Type in text in subject and body
CLick the back button
A confirmation message shows. Click cancel!

Expected: Edits retained you can continue editing.
Actual: Edits retained you can continue editing.

Now...

Press the BROWSER BACK Button
A confirmation message shows. Click cancel!

Expected: Edits retained you can continue editing.
Actual: MY EDITS ARE LOST FOREVER OHHHH NO

Developer notes

It's overriding Overlay.prototype.hide - we now encourage a onBeforeExit callback that is passed into the constructor.

QA Results

AC	Status	Details
1	✅	T228235#5363811

Details

	Subject	Repo	Branch	Lines +/-
	TalkSectionAddOverlay should use onBeforeExit function	mediawiki/extensions/MobileFrontend	master	+5 -6

Customize query in gerrit

Related Objects

Mentioned In: T228278: Edits lost when writing replies on talk page before leaving the page
Mentioned Here: T226106: Three clicks required to exit talk overlay

Event Timeline

Jdlrobson created this task.Jul 16 2019, 11:33 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 16 2019, 11:33 PM

Change 523829 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] TalkSectionAddOverlay should use onBeforeExit function

https://gerrit.wikimedia.org/r/523829

gerritbot added a project: Patch-For-Review.Jul 16 2019, 11:34 PM

Jdlrobson updated the task description. (Show Details)Jul 16 2019, 11:34 PM

Jdlrobson mentioned this in T228278: Edits lost when writing replies on talk page before leaving the page.Jul 17 2019, 3:05 PM

ovasileva triaged this task as Medium priority.Jul 17 2019, 3:41 PM

ovasileva set the point value for this task to 2.Jul 17 2019, 4:43 PM

Jdlrobson moved this task from Upcoming to Readers-Web-Kanbanana-2019-20-Q1 on the Web-Team-Backlog board.Jul 23 2019, 5:24 PM

Jdlrobson edited projects, added Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1); removed Web-Team-Backlog.

Jdlrobson moved this task from Needs Analysis to Needs Code Review on the Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.

Change 523829 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] TalkSectionAddOverlay should use onBeforeExit function

https://gerrit.wikimedia.org/r/523829

Jdlrobson assigned this task to Edtadros.Jul 24 2019, 12:53 AM

Jdlrobson moved this task from Needs Code Review to Needs QA on the Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.

Maintenance_bot removed a project: Patch-For-Review.Jul 24 2019, 1:10 AM

Test Result

Status: ✅ PASS
OS: macOS Mojave
Browser: Chrome
Device: MBP
Emulated Device: iPhoneX

Test Artifact(s):

QA Steps

Visit https://en.m.wikipedia.beta.wmflabs.org/wiki/Spain#/talk/new
Type in text in subject and body
CLick the back button
A confirmation message shows. Click cancel!
✅ AC1: Edits retained you can continue editing.