Page MenuHomePhabricator

Replace broken User::$mRights access in GraphViz
Open, Needs TriagePublic

Description

User::$mRights is not writable anymore, PermissionManager::addTemporaryUserRights() is provided as a replacement.

See T227772: Fix or remove capability to override user rights for the current request for background.

Event Timeline

Tgr created this task.Jul 17 2019, 8:21 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 17 2019, 8:21 AM

Change 524079 had a related patch set uploaded (by Samwilson; owner: Samwilson):
[mediawiki/extensions/GraphViz@master] Update to new user rights modifying

https://gerrit.wikimedia.org/r/524079

I've made a patch for this, but if we were to stop uploading graphs as images then this wouldn't be required at all. This is being discussed at T215391: Graphs are constantly being regenerated, no matter what.