Page MenuHomePhabricator

PHP Notice: Undefined property: stdClass::$module in OATHAuth/src/OATHUserRepository.php on line 193
Closed, ResolvedPublic

Description

The code seems to have been introduced in rEOATea984e5c2b2e: Refactor the extension to support multiple auth modules

The notice is followed by MWException from line 98 of OATHAuth/src/OATHUserRepository.php

Impact: Users unable to login, unable to access some special pages, including Special:AllPages.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 17 2019, 8:29 AM

This warning indicates that database table (oathauth_users) is not updated

I ran update.php. @MarcoAurelio can you login now?

TheDJ added a subscriber: TheDJ.EditedJul 17 2019, 12:22 PM

but.. have those db changes run on WMF production already then, because otherwise this might turn into a production issue. I only see a note of them having been deployed to beta.wmflabs

I ran update.php. @MarcoAurelio can you login now?

Yes, I could successfully login now. Thanks @Nikerabbit.

but.. have those db changes run on WMF production already then ? I only see a note of them having been deployed to beta.wmflabs

I think this is an important question.

but.. have those db changes run on WMF production already then ? I only see a note of them having been deployed to beta.wmflabs

I think this is an important question.

Given the patch metadata says Branches master, wmf/1.34.0-wmf.11, wmf/1.34.0-wmf.13, wmf/1.34.0-wmf.14 I would say it's likely that the changes have been done in WMF production, because otherwise we would have noticed already.

hashar added a subscriber: hashar.Jul 17 2019, 12:53 PM

Seems WMF production database had some schema changes recently for the oauth_users database table:

We do not seem to have any such error on WMF production. I thus guess translatewiki.net lacks the database change from MediaWiki-extensions-OATHAuth potentially because it is missing a database patcher for update.php?

Reedy added a comment.Jul 17 2019, 1:15 PM

Seems WMF production database had some schema changes recently for the oauth_users database table:

We do not seem to have any such error on WMF production. I thus guess translatewiki.net lacks the database change from MediaWiki-extensions-OATHAuth potentially because it is missing a database patcher for update.php?

No. It’s just because update.php wasn’t run. As evident by Niklas running it, and Marco being able to login

Prod was done, there are two tasks for it

Reedy closed this task as Resolved.Jul 17 2019, 1:15 PM
Reedy assigned this task to Nikerabbit.

Thanks for the help. For the record, I have added OATHAuth to the list of extensions I receive notifications for merged patches. But I wonder if there is a better way to make people aware of mandatory schema changes?

One of the reasons I'm not running update.php every time is T160993: MysqlUpdater::doWatchlistUpdate is very slow