Page MenuHomePhabricator

CSS with external links does not work well
Closed, ResolvedPublic

Description

See the picture in attachment: the external links have a big padding before.
This does not happens on the online version.
For an unknown reason, replacing "padding: 0 npx" by "padding-rigth: npx" resolves the issue without impacting the online version (see the patch in attachment)


Version: unspecified
Severity: normal

Details

Reference
bz20828

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:50 PM
bzimport set Reference to bz20828.
bzimport added a subscriber: Unknown Object (MLST).

Created attachment 6586
Modifications I have done to (partly) resolve the issue

Attached:

The problem rootcause is that in the SkinOffline.php the ltr/rtl class is not defined in the <body> CSS attribute. So please forget the previous patch, this is wrong.

Created attachment 7811
add rtl/ltr class to body of dumphtml

Fixing this is easy enough, see patch, but that leaves all the other "special" parts that a head can have. SkinOffline should be fixed to better reuse the <head> element of Skin.php I think.

Attached:

@ Derk-Jan Hartman

Yes this is what I have done on my mirror.

who should be getting dumpHTML bugs?

sumanah wrote:

Ariel, I think technically Tim Starling is the maintainer, so you could fling it to him.

sumanah wrote:

Derk-Jan, can I ask you to push this as a Gerrit merge request? Thanks.

Related URL: https://gerrit.wikimedia.org/r/60194 (Gerrit Change I3ca7102d40579b43af56e14b3f4bd8ddd33fb232)

Change 60194 merged by jenkins-bot:
SkinOffline: Add rtl/ltr classes to body

https://gerrit.wikimedia.org/r/60194

Patch got merged - can this bug report be closed as RESOLVED FIXED or is more work required?

No reply to comment 11 - assuming this is FIXED.
Please reopen and elaborate which work is left, if that is not the case.