JS Cannot read property 'find' of undefined on Beta cluster
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Edtadros
	Jul 17 2019, 4:21 PM

Description

On page https://en.m.wikipedia.beta.wmflabs.org/wiki/Qatar we see the following error:

VM94 mobile.init.js:1 Uncaught TypeError: Cannot read property 'find' of undefined
    at VM94 mobile.init.js:1
    at j (VM94 mobile.init.js:1)
    at e.exports (VM94 mobile.init.js:1)
    at Object../src/mobile.init/mobile.init.js (VM94 mobile.init.js:1)
    at f (VM38 load.php:9072)
    at t (VM38 load.php:9072)
    at Array.r [as push] (VM38 load.php:9072)
    at VM94 mobile.init.js:1
(anonymous) @ VM94 mobile.init.js:1
j @ VM94 mobile.init.js:1
e.exports @ VM94 mobile.init.js:1
./src/mobile.init/mobile.init.js @ VM94 mobile.init.js:1
f @ VM38 load.php:9072
t @ VM38 load.php:9072
r @ VM38 load.php:9072
(anonymous) @ VM94 mobile.init.js:1

This occurs on page load. The impact of this is that the header icons do not work. Different articles like https://en.m.wikipedia.beta.wmflabs.org/wiki/Dog work just fine. The Qatar page on production works fine.

OS: macOS Mojave
Browser: Chrome Version 75.0.3770.100 (Official Build) (64-bit)
Device: MBP
Emulated Device: iPhoneX

QA Results

AC	Status	Details
1	✅	T228298#5343816
2	✅	T228298#5343816

Details

	Subject	Repo	Branch	Lines +/-
	🐛 Bug: Fix Cannot read property 'find' of undefined error	mediawiki/extensions/MobileFrontend	master	+11 -10

Customize query in gerrit

Event Timeline

Edtadros created this task.Jul 17 2019, 4:21 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 17 2019, 4:21 PM

IS this still a problem (there was a related issue fixed? Pulling it to sprint as this is probably a recent regression.

pmiazga removed pmiazga as the assignee of this task.Jul 17 2019, 5:45 PM

pmiazga subscribed.

Reproduced when anonymous. Problematic code is:

currentPage.$el.find( '.mw-editsection' ).hide();

Restricted Application added a subscriber: Liuxinyu970226. · View Herald TranscriptJul 17 2019, 7:47 PM

Change 524005 had a related patch set uploaded (by Nray; owner: Nray):
[mediawiki/extensions/MobileFrontend@master] 🐛 Bug: Fix Cannot read property 'find' of undefined error

https://gerrit.wikimedia.org/r/524005

gerritbot added a project: Patch-For-Review.Jul 17 2019, 8:02 PM

Change 524005 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] 🐛 Bug: Fix Cannot read property 'find' of undefined error

https://gerrit.wikimedia.org/r/524005

@Edtadros this should be fixed now if you check the page again. Thanks for noticing this and bringing it up!

Maintenance_bot removed a project: Patch-For-Review.Jul 17 2019, 9:10 PM

Jdlrobson lowered the priority of this task from Unbreak Now! to High.Jul 17 2019, 9:28 PM

Test Result

Status: ✅ PASS
OS: macOS Mojave
Browser: Chrome
Device: MBP
Emulated Device: iPhoneX

Test Artifact(s):

QA Steps

✅ AC1: Navigate to https://en.m.wikipedia.beta.wmflabs.org/wiki/Qatar. This error should not appear in the console: TypeError: Cannot read property 'find' of undefined.

en.m.wikipedia.beta.wmflabs.org-1563407706066.log20 KBDownload

✅ AC2: Header buttons should work.

About System - Edited.gif (1×750 px, 2 MB)

Edtadros updated the task description. (Show Details)Jul 18 2019, 12:02 AM

• Niedzielski closed this task as Resolved.Jul 22 2019, 5:14 PM

	F29796129: en.m.wikipedia.beta.wmflabs.org-1563407706066.log
	Jul 18 2019, 12:01 AM

JS Cannot read property 'find' of undefined on Beta clusterClosed, ResolvedPublicActions