Page MenuHomePhabricator

Switch translatewiki repo from composer-test-hhvm to composer-test
Closed, ResolvedPublic

Description

Translatewiki.net has switched from HHVM to PHP a while ago, so there is no benefit of testing with HHVM instead of PHP.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 18 2019, 6:19 AM
hashar added a subscriber: hashar.Jul 18 2019, 7:54 AM

integration/config.git has:

zuul/layout.yaml
- name: translatewiki
  test:
    - translatewiki-rake-docker
    - translatewiki-composer-hhvm-docker
  gate-and-submit:
    - translatewiki-rake-docker
    - translatewiki-composer-hhvm-docker

Which PHP version should we use? CI should be able to test against 7.0, 7.1 and/or 7.2.

Per https://translatewiki.net/wiki/Special:Version they're running PHP 7.1.30-1+ubuntu16.04.1+deb.sury.org+1 (fpm-fcgi) so let's go with 7.1 for now?

greg triaged this task as Normal priority.Mon, Jul 29, 4:39 PM

Change 526191 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[integration/config@master] layout: [translatewiki] Provide experimental PHP72 job to replace HHVM one

https://gerrit.wikimedia.org/r/526191

Change 526192 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[integration/config@master] layout: [translatewiki] Make PHP72 job voting, drop HHVM one

https://gerrit.wikimedia.org/r/526192

Change 526193 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[integration/config@master] jjb: Drop translatewiki-composer-hhvm-docker, unused

https://gerrit.wikimedia.org/r/526193

Change 526191 merged by jenkins-bot:
[integration/config@master] layout: [translatewiki] Provide experimental PHP72 job to replace HHVM one

https://gerrit.wikimedia.org/r/526191

Per https://translatewiki.net/wiki/Special:Version they're running PHP 7.1.30-1+ubuntu16.04.1+deb.sury.org+1 (fpm-fcgi) so let's go with 7.1 for now?

Sadly we don't have a PHP 7.1 test set-up for this; I'll got with PHP 7.2 for now.

Mentioned in SAL (#wikimedia-releng) [2019-07-29T18:13:34Z] <James_F> Zuul: [translatewiki] T228376 Provide experimental PHP72 job to replace HHVM one

Change 526192 merged by jenkins-bot:
[integration/config@master] layout: [translatewiki] Make PHP72 job voting, drop HHVM one

https://gerrit.wikimedia.org/r/526192

Mentioned in SAL (#wikimedia-releng) [2019-07-29T18:23:02Z] <James_F> Zuul: [translatewiki] T228376 Make PHP72 job voting, drop HHVM one

Jdforrester-WMF closed this task as Resolved.Mon, Jul 29, 6:24 PM
Jdforrester-WMF removed a project: Patch-For-Review.

Change 526193 merged by jenkins-bot:
[integration/config@master] jjb: Drop translatewiki-composer-hhvm-docker, unused

https://gerrit.wikimedia.org/r/526193