Page MenuHomePhabricator
Create Task
Maniphest T228376

Switch translatewiki repo from composer-test-hhvm to composer-test
Closed, ResolvedPublic
Actions

Description

Translatewiki.net has switched from HHVM to PHP a while ago, so there is no benefit of testing with HHVM instead of PHP.

Details

SubjectRepoBranchLines +/-
jjb: Drop translatewiki-composer-hhvm-docker, unusedintegration/configmaster+0 -5
layout: [translatewiki] Make PHP72 job voting, drop HHVM oneintegration/configmaster+1 -3
layout: [translatewiki] Provide experimental PHP72 job to replace HHVM oneintegration/configmaster+2 -0
Customize query in gerrit

Event Timeline

Nikerabbit created this task.Jul 18 2019, 6:19 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 18 2019, 6:19 AM
hashar added a subscriber: hashar.Jul 18 2019, 7:54 AM

integration/config.git has:

zuul/layout.yaml
- name: translatewiki
  test:
    - translatewiki-rake-docker
    - translatewiki-composer-hhvm-docker
  gate-and-submit:
    - translatewiki-rake-docker
    - translatewiki-composer-hhvm-docker

Which PHP version should we use? CI should be able to test against 7.0, 7.1 and/or 7.2.

hashar added projects: Release-Engineering-Team (CI & Testing services), Release-Engineering-Team-TODO (201907).Jul 18 2019, 7:55 AM
Jdforrester-WMF added a subscriber: Jdforrester-WMF.Jul 29 2019, 3:52 PM

Per https://translatewiki.net/wiki/Special:Version they're running PHP 7.1.30-1+ubuntu16.04.1+deb.sury.org+1 (fpm-fcgi) so let's go with 7.1 for now?

Jdforrester-WMF claimed this task.Jul 29 2019, 4:08 PM
Jdforrester-WMF moved this task from INBOX to Doing on the Release-Engineering-Team-TODO (201907) board.
greg triaged this task as Medium priority.Jul 29 2019, 4:39 PM
gerritbot added a comment.Jul 29 2019, 5:49 PM

Change 526191 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[integration/config@master] layout: [translatewiki] Provide experimental PHP72 job to replace HHVM one

https://gerrit.wikimedia.org/r/526191

gerritbot added a project: Patch-For-Review.Jul 29 2019, 5:49 PM

Change 526192 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[integration/config@master] layout: [translatewiki] Make PHP72 job voting, drop HHVM one

https://gerrit.wikimedia.org/r/526192

gerritbot added a comment.Jul 29 2019, 5:49 PM

Change 526193 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[integration/config@master] jjb: Drop translatewiki-composer-hhvm-docker, unused

https://gerrit.wikimedia.org/r/526193

gerritbot added a comment.Jul 29 2019, 6:09 PM

Change 526191 merged by jenkins-bot:
[integration/config@master] layout: [translatewiki] Provide experimental PHP72 job to replace HHVM one

https://gerrit.wikimedia.org/r/526191

Jdforrester-WMF added a comment.Jul 29 2019, 6:10 PM
In T228376#5373162, @Jdforrester-WMF wrote:

Per https://translatewiki.net/wiki/Special:Version they're running PHP 7.1.30-1+ubuntu16.04.1+deb.sury.org+1 (fpm-fcgi) so let's go with 7.1 for now?

Sadly we don't have a PHP 7.1 test set-up for this; I'll got with PHP 7.2 for now.

Stashbot added a comment.Jul 29 2019, 6:13 PM

Mentioned in SAL (#wikimedia-releng) [2019-07-29T18:13:34Z] <James_F> Zuul: [translatewiki] T228376 Provide experimental PHP72 job to replace HHVM one

gerritbot added a comment.Jul 29 2019, 6:21 PM

Change 526192 merged by jenkins-bot:
[integration/config@master] layout: [translatewiki] Make PHP72 job voting, drop HHVM one

https://gerrit.wikimedia.org/r/526192

Stashbot added a comment.Jul 29 2019, 6:23 PM

Mentioned in SAL (#wikimedia-releng) [2019-07-29T18:23:02Z] <James_F> Zuul: [translatewiki] T228376 Make PHP72 job voting, drop HHVM one

Jdforrester-WMF closed this task as Resolved.Jul 29 2019, 6:24 PM
Jdforrester-WMF moved this task from Doing to Completed on the Release-Engineering-Team-TODO (201907) board.
Jdforrester-WMF removed a project: Patch-For-Review.
gerritbot added a comment.Jul 29 2019, 6:26 PM

Change 526193 merged by jenkins-bot:
[integration/config@master] jjb: Drop translatewiki-composer-hhvm-docker, unused

https://gerrit.wikimedia.org/r/526193

Nikerabbit added a comment.Aug 24 2019, 10:42 AM

Thanks @Jdforrester-WMF!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL