TopicListBlock.php sort order params
Closed, DuplicatePublicPRODUCTION ERROR
Actions

Assigned To

None

Authored By

	• LarsWirzenius
	Jul 18 2019, 11:41 AM

Description

Error

Request URL: www.mediawiki.org/w/index.php?title=XXX&topiclist_offset-dir=fwd&topiclist_limit=10&topiclist_offset=20141201103819&topiclist_sortby=Ds3wdoJZ
Request ID: XTBXoQpAADwAAAbXFW8AAACJ

message

[{exception_id}] {exception_url}   Flow\Exception\FlowException from line 396 of /srv/mediawiki/php-1.34.0-wmf.14/extensions/Flow/includes/Block/TopicListBlock.php: The `newest` sort order does not allow the `offset` parameter.  Please use `offset-id`.

trace

#0 /srv/mediawiki/php-1.34.0-wmf.14/extensions/Flow/includes/Block/TopicListBlock.php(257): Flow\Block\TopicListBlock->getFindOptions(array)
#1 /srv/mediawiki/php-1.34.0-wmf.14/extensions/Flow/includes/View.php(235): Flow\Block\TopicListBlock->renderApi(array)
#2 /srv/mediawiki/php-1.34.0-wmf.14/extensions/Flow/includes/View.php(71): Flow\View->buildApiResponse(Flow\WorkflowLoader, array, string, array)
#3 /srv/mediawiki/php-1.34.0-wmf.14/extensions/Flow/includes/Actions/Action.php(112): Flow\View->show(Flow\WorkflowLoader, string)
#4 /srv/mediawiki/php-1.34.0-wmf.14/extensions/Flow/includes/Actions/ViewAction.php(20): Flow\Actions\FlowAction->showForAction(string, OutputPage)
#5 /srv/mediawiki/php-1.34.0-wmf.14/extensions/Flow/includes/Actions/Action.php(50): Flow\Actions\ViewAction->showForAction(string)
#6 /srv/mediawiki/php-1.34.0-wmf.14/includes/MediaWiki.php(499): Flow\Actions\FlowAction->show()
#7 /srv/mediawiki/php-1.34.0-wmf.14/includes/MediaWiki.php(294): MediaWiki->performAction(Article, Title)
#8 /srv/mediawiki/php-1.34.0-wmf.14/includes/MediaWiki.php(884): MediaWiki->performRequest()
#9 /srv/mediawiki/php-1.34.0-wmf.14/includes/MediaWiki.php(515): MediaWiki->main()
#10 /srv/mediawiki/php-1.34.0-wmf.14/index.php(42): MediaWiki->run()
#11 /srv/mediawiki/w/index.php(3): include(string)
#12 {main}

Impact

To be determined.

Notes

This is a new error and thus I'm treating it as a train blocker until I'm told otherwise. Thank you.

Related Objects

Mentioned Here: T211798: [{exception_id}] {exception_url} Flow\Exception\FlowException from line 397 of /srv/mediawiki/php-1.33.0-wmf.8/extensions/Flow/includes/Block/TopicListBlock.php: The `newest` sort order does not allow the `offset` parameter. Please use `offset-id`
T228417: RevisionFormatter.php: Unknown content format

Event Timeline

• LarsWirzenius created this task.Jul 18 2019, 11:41 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 18 2019, 11:41 AM

• LarsWirzenius triaged this task as Unbreak Now! priority.Jul 18 2019, 11:41 AM

Restricted Application added a subscriber: Liuxinyu970226. · View Herald TranscriptJul 18 2019, 11:41 AM

• LarsWirzenius added a project: StructuredDiscussions.Jul 18 2019, 11:44 AM

• LarsWirzenius added a subscriber: Growth-Team.

Restricted Application added a project: Growth-Team. · View Herald TranscriptJul 18 2019, 11:45 AM

This is strangely similar to T228417: RevisionFormatter.php: Unknown content format

This URL is used in the non-javascript experience to load new topics at the end of a long Flow board.

The combination of sort and offset (as opposed to offset-id) is what breaks here but the sortby parameter has gibberish very similar to what we observed in the task above.

I recommend we downgrade to High and remove as train blocker while we investigate.

Thanks. I'll downgrade and remove as blocker.

• LarsWirzenius lowered the priority of this task from Unbreak Now! to High.Jul 18 2019, 1:19 PM

• LarsWirzenius removed a parent task: T220739: 1.34.0-wmf.14 deployment blockers.

Krinkle moved this task from Untriaged to Jul2019/1.34.wmf.13+ on the Wikimedia-production-error board.Jul 18 2019, 3:33 PM

This is probably a duplicate of T211798, right?

In T228406#5346309, @Catrope wrote:

This is probably a duplicate of T211798, right?

Right

SBisson closed this task as a duplicate of T211798: [{exception_id}] {exception_url} Flow\Exception\FlowException from line 397 of /srv/mediawiki/php-1.33.0-wmf.8/extensions/Flow/includes/Block/TopicListBlock.php: The `newest` sort order does not allow the `offset` parameter. Please use `offset-id`.Jul 18 2019, 3:49 PM

Restricted Application removed a subscriber: Liuxinyu970226. · View Herald TranscriptJul 18 2019, 3:49 PM

matmarex added a project: Editing-team.Jul 19 2019, 3:48 PM

matmarex removed subscribers: Growth-Team, Editing-team.

• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:06 PM

TopicListBlock.php sort order paramsClosed, DuplicatePublicPRODUCTION ERRORActions