| Jdrewniak | |
| Jul 18 2019, 12:24 PM |
| F29846483: Spain - Wikipedia the free encyclopedia.gif | |
| Jul 22 2019, 11:48 PM |
| F29800436: Talk Not Updating.2019-07-18 14_22_39.gif | |
| Jul 18 2019, 12:24 PM |
Discovered by @Edtadros while QA'ing T226106, the talk overlay does not update the list with new threads after they have been created. This is reproducible on master, with no console errors.
Please test this on the beta cluster: https://en.m.wikipedia.beta.wmflabs.org/wiki/Spain
| AC | Status | Details |
|---|---|---|
| 1 | ✅ | T228418#5355839 |
Topic is added but the overlay does not refresh (no new topic appended and no api request made). Closing this overlay seems to show the overlay below that's cached without the required update. An event talk-discussion-added is fired. I think the overlay needs to subscribe to this and react to that change (potentially just generate a new instance of itself and replace it using overlayManager.replace)
Change 524322 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Refresh talk overlay after new topic added
Change 524367 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] After a save the talk section overlay is rendered
Change 524375 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] onSaveComplete callback is no longer optional
Change 524367 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] After a save the talk section overlay is rendered
Change 524322 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Talk overlays for creating new topics now use callback
Change 524375 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] onSaveComplete callback is no longer optional
Status: ✅ PASS
OS: macOS Mojave
Browser: Chrome
Device: MBP
Emulated Device: iPhoneX
Test Artifact(s):
✅ AC1:
