Page MenuHomePhabricator

Special:SpecialPages throws error when not logged in
Closed, ResolvedPublic

Description

First discovered in: https://www.mediawiki.org/wiki/Topic:Uypt7bxm77hdtya6

[e6e05d380cdebbdee0eb868e] /w/index.php?title=Special:SpecialPages TypeError from line 19 of /code/w/extensions/GoogleLogin/includes/GoogleIdProvider.php: Argument 1 passed to GoogleLogin\GoogleIdProvider::getFromUser() must be an instance of User, bool given, called in /code/w/extensions/GoogleLogin/includes/Auth/GooglePrimaryAuthenticationProvider.php on line 106

Backtrace:

#0 /code/w/extensions/GoogleLogin/includes/Auth/GooglePrimaryAuthenticationProvider.php(106): GoogleLogin\GoogleIdProvider->getFromUser(boolean)
#1 /code/w/includes/auth/AuthManager.php(2104): GoogleLogin\Auth\GooglePrimaryAuthenticationProvider->getAuthenticationRequests(string, array)
#2 /code/w/includes/auth/AuthManager.php(2082): MediaWiki\Auth\AuthManager->getAuthenticationRequestsInternal(string, array, array, User)
#3 /code/w/includes/specialpage/AuthManagerSpecialPage.php(256): MediaWiki\Auth\AuthManager->getAuthenticationRequests(string, User)
#4 /code/w/includes/specials/SpecialChangeCredentials.php(93): AuthManagerSpecialPage->loadAuth(string, NULL)
#5 /code/w/includes/specials/SpecialChangeCredentials.php(30): SpecialChangeCredentials->loadAuth(string)
#6 /code/w/includes/specialpage/SpecialPageFactory.php(452): SpecialChangeCredentials->isListed()
#7 /code/w/includes/specials/SpecialSpecialpages.php(56): MediaWiki\Special\SpecialPageFactory->getUsablePages(User)
#8 /code/w/includes/specials/SpecialSpecialpages.php(44): SpecialSpecialpages->getPageGroups()
#9 /code/w/includes/specialpage/SpecialPage.php(571): SpecialSpecialpages->execute(NULL)
#10 /code/w/includes/specialpage/SpecialPageFactory.php(581): SpecialPage->run(NULL)
#11 /code/w/includes/MediaWiki.php(288): MediaWiki\Special\SpecialPageFactory->executePath(Title, RequestContext)
#12 /code/w/includes/MediaWiki.php(884): MediaWiki->performRequest()
#13 /code/w/includes/MediaWiki.php(515): MediaWiki->main()
#14 /code/w/index.php(42): MediaWiki->run()
#15 {main}

Event Timeline

Florian created this task.Jul 18 2019, 4:03 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 18 2019, 4:03 PM

Change 524264 had a related patch set uploaded (by Florianschmidtwelzow; owner: Florianschmidtwelzow):
[mediawiki/extensions/GoogleLogin@master] Fix exception on not-logged-in Special:SpecialPages request

https://gerrit.wikimedia.org/r/524264

Change 524264 merged by Florianschmidtwelzow:
[mediawiki/extensions/GoogleLogin@master] Fix exception on not-logged-in Special:SpecialPages request

https://gerrit.wikimedia.org/r/524264

Florian closed this task as Resolved.Jul 20 2019, 10:31 AM
Florian removed a project: Patch-For-Review.