For a few days now we've been getting cronspam like this:
Cron <www-data@labweb1001> /usr/local/bin/mwscript extensions/TorBlock/maintenance/loadExitNodes.php --wiki=labswiki --force > /dev/null Could not load exit nodes.
I'm not sure what the correct behavior for this is on labweb* but I suspect these errors are due to recent changes in the extension.
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T294906 Puppet Improvements | |||
| Duplicate | jbond | T265138 Work required to prepare for puppet 7 | |||
| Resolved | SLyngshede-WMF | T273673 replace all puppet crons with systemd timers | |||
| Open | None | T132324 Tracking and Reducing cron-spam to root@ | |||
| Resolved | Release | • LarsWirzenius | T220739 1.34.0-wmf.14 deployment blockers | ||
| Resolved | aaron | T228465 TorBlock maintenance failures on labweb hosts |
Change 524326 had a related patch set uploaded (by Aaron Schulz; owner: Aaron Schulz):
[mediawiki/extensions/TorBlock@master] Fix LoadExitNodes.php when $wgTorLoadNodes is false
Change 524329 had a related patch set uploaded (by Aaron Schulz; owner: Aaron Schulz):
[mediawiki/extensions/TorBlock@wmf/1.34.0-wmf.14] Fix LoadExitNodes.php when $wgTorLoadNodes is false
Change 524329 abandoned by Aaron Schulz:
Fix LoadExitNodes.php when $wgTorLoadNodes is false
Reason:
base patch changing
For posterity, this issue generates the following error being mailed:
Cron <www-data@labweb1001> /usr/local/bin/mwscript extensions/TorBlock/maintenance/loadExitNodes.php --wiki=labswiki --force > /dev/null Could not load exit nodes.
Change 524329 restored by Jforrester:
Fix LoadExitNodes.php when $wgTorLoadNodes is false
Change 524326 merged by jenkins-bot:
[mediawiki/extensions/TorBlock@master] Fix LoadExitNodes.php when $wgTorLoadNodes is false
It sounds interesting. How can Tor blocks create such errors? Tor exit nodes are usually detectable, how can the software bug be like this magnitude?
Change 524329 merged by jenkins-bot:
[mediawiki/extensions/TorBlock@wmf/1.34.0-wmf.14] Fix LoadExitNodes.php when $wgTorLoadNodes is false
Mentioned in SAL (#wikimedia-operations) [2019-07-22T04:44:16Z] <tstarling@deploy1001> Synchronized php-1.34.0-wmf.14/extensions/TorBlock/includes/TorExitNodes.php: fixing UBN T228465 (duration: 00m 56s)
Mentioned in SAL (#wikimedia-operations) [2019-07-22T04:46:07Z] <tstarling@deploy1001> Synchronized php-1.34.0-wmf.14/extensions/TorBlock/maintenance/loadExitNodes.php: fixing UBN T228465 (duration: 00m 54s)
Mentioned in SAL (#wikimedia-operations) [2019-07-22T04:48:53Z] <tstarling@deploy1001> Synchronized php-1.34.0-wmf.14/extensions/TorBlock/extension.json: fixing UBN T228465 (duration: 00m 54s)
Fixed and confirmed
[0450][www-data@labweb1001:/]$ time /usr/local/bin/mwscript extensions/TorBlock/maintenance/loadExitNodes.php --wiki=labswiki --force Successfully loaded 1206 exit nodes. real 0m1.958s user 0m0.572s sys 0m0.212s
I guess the cron jobs should be removed now, is there a bug for that?
If loadExitNodes.php is obsolete now, from what I understand, it would be great if the change gets documented on the extension page