Page MenuHomePhabricator
Create Task
Maniphest T228467

thumbtime/seek thumbnailing broken with floating point offsets
Open, LowPublic
Actions

Description

It seems that the seek param of thumbor is no longer working as expected.
A url like:
https://upload.wikimedia.org/wikipedia/commons/thumb/f/f3/Parus_major,_Germany_2009.ogv/300px-seek=2.5-Parus_major,_Germany_2009.ogv.jpg

should return an image from 2.5 seconds into the movie File:Parus_major,_Germany_2009.ogv but instead it shows the midway frame of the video.

This used to work...

Actually it seems https://upload.wikimedia.org/wikipedia/commons/thumb/f/f3/Parus_major,_Germany_2009.ogv/300px-seek=2-Parus_major,_Germany_2009.ogv.jpg
still works, so it's the floating point parsing that this fails on..

https://phabricator.wikimedia.org/diffusion/THMBREXT/browse/master/wikimedia_thumbor/loader/video/__init__.py$163

has int() which does indeed fail on floating numbers. Having subsecond thumbtimes is actually useful, as there can be 24 up to 60 frames in a second and this frame picking can definitely make a big difference.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Add decimal seek offset for videosoperations/software/thumbor-pluginsmaster+12 -3
Add decimal seek offset for videosoperations/software/thumbor-pluginsmaster+12 -3
Customize query in gerrit

Related Objects

Event Timeline

TheDJ created this task.Jul 18 2019, 7:44 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 18 2019, 7:44 PM
TheDJ renamed this task from thumbtime/seek thumbnailing broken to thumbtime/seek thumbnailing broken with floating point offsets.Jul 18 2019, 7:46 PM
TheDJ updated the task description. (Show Details)
gerritbot added a comment.Jul 18 2019, 8:41 PM

Change 524330 had a related patch set uploaded (by TheDJ; owner: TheDJ):
[operations/software/thumbor-plugins@master] Add decimal seek offset for videos

https://gerrit.wikimedia.org/r/524330

gerritbot added a project: Patch-For-Review.Jul 18 2019, 8:41 PM
• Gilles claimed this task.Aug 19 2019, 4:51 PM
• Gilles added a project: Performance-Team.

Came back from vacation today. There is a pending thumbor-plugins deployment pending for T226707: cwebp chokes on YCCK JPGs already. Once that has gone through, I will take care of this fix getting merged and deployed.

• Gilles moved this task from Inbox, needs triage to Doing (old) on the Performance-Team board.Aug 19 2019, 8:12 PM
• Gilles moved this task from Doing (old) to Blocked (old) on the Performance-Team board.Sep 30 2019, 8:38 PM
• Gilles triaged this task as Low priority.Jan 6 2020, 1:18 PM
gerritbot added a comment.Jan 29 2020, 9:55 PM

Change 524330 abandoned by TheDJ:
Add decimal seek offset for videos

https://gerrit.wikimedia.org/r/524330

TheDJ added a comment.Jan 29 2020, 9:59 PM

abandoned because i can't move this forward. whoever wants to fix it can take over the patch

Krinkle removed a project: Patch-For-Review.Jan 29 2020, 9:59 PM
gerritbot added a comment.Jan 29 2020, 10:32 PM

Change 568646 had a related patch set uploaded (by Brion VIBBER; owner: Brion VIBBER):
[operations/software/thumbor-plugins@master] Add decimal seek offset for videos

https://gerrit.wikimedia.org/r/568646

gerritbot added a project: Patch-For-Review.Jan 29 2020, 10:32 PM
• Gilles added a project: EngProd-Virtual-Hackathon.May 12 2020, 3:39 PM
AntiCompositeNumber moved this task from Backlog to Thumbnail quality on the Thumbor board.May 22 2020, 4:06 AM
• Gilles removed a project: EngProd-Virtual-Hackathon.May 25 2020, 8:39 AM
Krinkle moved this task from Blocked (old) to Inbox, needs triage on the Performance-Team board.Mar 2 2021, 9:14 PM
Krinkle subscribed.

Moving old Blocked column with unclear status to Inbox.

• Gilles changed the task status from Open to Stalled.Mar 8 2021, 7:39 PM
• Gilles moved this task from Inbox, needs triage to Backlog: Maintenance, non-prioritized on the Performance-Team board.
• Gilles removed • Gilles as the assignee of this task.Jun 22 2021, 12:43 PM
• Gilles subscribed.
Krinkle removed a project: Patch-For-Review.Apr 14 2022, 12:26 AM
Krinkle edited projects, added Performance-Team (Radar), Platform Engineering; removed Performance-Team.
Krinkle moved this task from Limbo to Watching on the Performance-Team (Radar) board.
Krinkle removed a project: Performance-Team (Radar).Aug 18 2023, 8:14 PM
Aklapper changed the task status from Stalled to Open.Apr 6 2024, 7:33 AM

The previous comments don't explain who or what (task?) exactly this task is stalled on ("If a report is waiting for further input (e.g. from its reporter or a third party) and can currently not be acted on"). Hence resetting task status, as tasks should not be stalled (and then potentially forgotten) for years for unclear reasons.

Wladek92 subscribed.Apr 10 2025, 10:36 AM

Coming back for 'pro' on the topic: we need a flash of lightning at 7.8 on page -> https://commons.wikimedia.org/wiki/Commons:Video#Setting_a_video_thumbnail_image and all happens between sec 7 and sec 8 . So we have no choice between black.... and black images.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits