Page MenuHomePhabricator

thumbtime/seek thumbnailing broken with floating point offsets
Open, Needs TriagePublic

Description

It seems that the seek param of thumbor is no longer working as expected.
A url like:
https://upload.wikimedia.org/wikipedia/commons/thumb/f/f3/Parus_major,_Germany_2009.ogv/300px-seek=2.5-Parus_major,_Germany_2009.ogv.jpg

should return an image from 2.5 seconds into the movie File:Parus_major,_Germany_2009.ogv but instead it shows the midway frame of the video.

This used to work...

Actually it seems https://upload.wikimedia.org/wikipedia/commons/thumb/f/f3/Parus_major,_Germany_2009.ogv/300px-seek=2-Parus_major,_Germany_2009.ogv.jpg
still works, so it's the floating point parsing that this fails on..

https://phabricator.wikimedia.org/diffusion/THMBREXT/browse/master/wikimedia_thumbor/loader/video/__init__.py$163

has int() which does indeed fail on floating numbers. Having subsecond thumbtimes is actually useful, as there can be 24 up to 60 frames in a second and this frame picking can definitely make a big difference.

Related Objects

Event Timeline

TheDJ created this task.Jul 18 2019, 7:44 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 18 2019, 7:44 PM
TheDJ renamed this task from thumbtime/seek thumbnailing broken to thumbtime/seek thumbnailing broken with floating point offsets.Jul 18 2019, 7:46 PM
TheDJ updated the task description. (Show Details)

Change 524330 had a related patch set uploaded (by TheDJ; owner: TheDJ):
[operations/software/thumbor-plugins@master] Add decimal seek offset for videos

https://gerrit.wikimedia.org/r/524330

Gilles claimed this task.Aug 19 2019, 4:51 PM
Gilles added a project: Performance-Team.

Came back from vacation today. There is a pending thumbor-plugins deployment pending for T226707: cwebp chokes on YCCK JPGs already. Once that has gone through, I will take care of this fix getting merged and deployed.

Gilles moved this task from Inbox to Doing on the Performance-Team board.Aug 19 2019, 8:12 PM