Page MenuHomePhabricator

Remove "Browse Gerrit Projects" on https://phabricator.wikimedia.org/r/
Closed, ResolvedPublic

Description

Our Phabricator install has a Gerrit Application at https://phabricator.wikimedia.org/r/. Unless it is needed, I am proposing to disable it because their listings are outdated. To update them you have to manually submit patches to rPHEX via Differential using Arcanist. Usage of Differential for code review is discouraged at this moment, and manually updating the listings each time a extension is added or removed feels cumbersome. The last update of the code was done on a74bf951f05f, more than a year ago.

If the repository updates could be automated or semi-automated I'd certainly wouldn't mind keeping it. In fact I don't mind keeping it but it looks to me that it's nor providing a service as things stand now, and just adds a maintenance cost for whoever wants to keep that up and running.

Thank you.

Details

Related Changes in GitLab:
TitleReferenceAuthorSource BranchDest Branch
Remove the Gerrit applicationrepos/phabricator/extensions!36aklapperT228507rmGerritAppwmf/stable
Remove the Gerrit applicationrepos/phabricator/extensions!5aklapperaklapper-wmf/stable-patch-37894wmf/stable
Customize query in GitLab

Revisions and Commits

Event Timeline

Aklapper renamed this task from Disable Phabricator's Gerrit application to Disable "Browse Gerrit Projects" on https://phabricator.wikimedia.org/r/.Jul 19 2019, 12:04 PM

@MarcoAurelio I intend to automate the updates of this page, I just haven't gotten around to it. I still find it useful but maybe it's not worth the effort to write the automation.

I intend to automate the updates of this page

@mmodell: If there is no working concept to keep yet another listing page updated, could that page please be disabled?
(Hmm, how to discover / find that page anyway?)

@Aklapper: it is sufficiently obsolete at this point...

What needs to be done / how to remove that page properly?

Is this about simply git rming src/gerrit/GerritProjectListController.php and src/gerrit/GerritProjectMap.php in rPHEX?
I assume these two files don't need to be also manually removed from the list in __phutil_library_map__.php?
I assume src/gerrit/GerritProjectController.php should remain as is?

the library map is updated with arc liberate ./src after removing the files. Otherwise I think that's about right. There is also a need to remove the url routing from the GerritApplication.php I believe.

Mainframe98 added a revision: Restricted Differential Revision.Dec 3 2022, 12:55 PM

@Dzahn if you need to phase out the Differential repo rPHEX , we can migrate it to Gerrit which is very straightforward. I did it for the Phabricator translations (T321350) and there is T321380 about the various Phabricator repos.

@Dzahn if you need to phase out the Differential repo rPHEX , we can migrate it to Gerrit which is very straightforward. I did it for the Phabricator translations (T321350) and there is T321380 about the various Phabricator repos.

I'm moving everything in the deployment repo to GitLab:

https://gitlab.wikimedia.org/repos/phabricator

...will update T321380 accordingly.

LSobanski triaged this task as Low priority.
LSobanski moved this task from Incoming to Backlog on the collaboration-services board.

Seems to be defined in repo https://gitlab.wikimedia.org/repos/phabricator/extensions .
./src/gerrit/GerritProjectListController.php: $page->setBaseURI('/r/');
and some stuff in the files ./src/gerrit/GerritApplication.php plus probably entire ./src/gerrit/GerritProjectMap.php

Done in https://gitlab.wikimedia.org/repos/phabricator/extensions/-/merge_requests/5 : I just copied Mainframe98's patch from Differential into GitLab; not tested.

Thanks - I'll test and tweak if needed.

Once we get this disabled it may or may not also close this other ticket: T324311

I still have https://gerrit.wikimedia.org/r/c/operations/puppet/+/879137 for that redirect. So making that rewrite rule actually work as in the test.. is what we want here,, afair.

brennen merged https://gitlab.wikimedia.org/repos/phabricator/extensions/-/merge_requests/5

Remove the Gerrit application

Reverted temporarily. Works cleanly for removing the application, but a redirect should probably be in place.

I am fine with redirect breakage. Reducing maintenance complexity and removing outdated information is more important to me personally.
(Indeed, redirects like https://phabricator.wikimedia.org/r/revision/mediawiki/extensions/LookupUser;a99f7f54b4cfed214e0f2b7eadaa33e9da65d5ce would not end up anymore on https://phabricator.wikimedia.org/rELOUa99f7f54b4cfed214e0f2b7eadaa33e9da65d5ce.)

FYI https://logstash.wikimedia.org/goto/1f5706739d7cff2d3fc1ca0211ac73a7 shows the hits it got for the last 30 days (some are crawlers though)

Reverted temporarily.

Could we revert the revert?

@brennen: Could we deploy this again, or do you have concerns?

Note to myself: https://we.phorge.it/D25634 merged in upstream on 2024-05-16 would break this custom code.

Aklapper renamed this task from Disable "Browse Gerrit Projects" on https://phabricator.wikimedia.org/r/ to Remove "Browse Gerrit Projects" on https://phabricator.wikimedia.org/r/.May 28 2024, 12:33 PM
Aklapper claimed this task.
Aklapper edited projects, added Phabricator (2024-05-28); removed Patch-For-Review.

This got deployed/resolved on 2024-05-28.