Page MenuHomePhabricator

Delete unused custom /src/other/CustomLoginHandler.php in Phab extensions
Open, LowestPublic

Description

Delete https://phabricator.wikimedia.org/source/phab-extensions/browse/wmf%252Fstable/src/other/CustomLoginHandler.php as it is unused (see https://phabricator.wikimedia.org/T223926).

I would love to do that but it looks like Gerrit patches are not accepted (fatal: Upload denied for project 'phabricator/extensions', fatal: Could not read from remote repository.) and I'm growing tired of having to remember four different workflows (Gerrit, Differential, Gitlab, Github) in my life.

Details

Event Timeline

Aklapper triaged this task as Lowest priority.Jul 19 2019, 2:04 PM
Aklapper created this task.
Mainframe98 added a subscriber: Mainframe98.

There's also https://phabricator.wikimedia.org/differential/diff/create/, in which you can paste a diff, which is how I created D1151.

I've also updated https://www.mediawiki.org/wiki/Phabricator/Differential with instructions on how to create changes without using arcanist.

@Mainframe98: Uh, thanks a lot (also for documenting that)! Didn't know about that!

Is there anything left to do for D1151? I couldn't find any instructions on what to do once the revision has been accepted. I also don't see a way to rerun the tests; previously they failed because harbormaster couldn't connect to Jenkins (B3231).

Is there anything left to do for D1151? I couldn't find any instructions on what to do once the revision has been accepted. I also don't see a way to rerun the tests; previously they failed because harbormaster couldn't connect to Jenkins (B3231).

@mmodell: Any idea, maybe?

Urbanecm removed the point value for this task.Sat, Aug 31, 11:27 PM
Urbanecm added a subscriber: Urbanecm.

[bulk] Setting points to "", given it doesn't make any sense to have them as "0".