Page MenuHomePhabricator

"DisplayTitleHooks.php": Call to a member function isTalkPage() on null
Closed, ResolvedPublic

Description

Setup

  • MediaWiki 1.33.0 (1c47e93) 15:49, 16. Jul. 2019
  • PHP 7.2.19-0ubuntu0.18.04.1 (apache2handler)
  • MariaDB 10.1.40-MariaDB-0ubuntu0.18.04.1
  • DisplayTitle 2.0.0 (0705659) 14:51, 6. Feb. 2019

Issue
Originally reported here.

[ddc4653e9eff034859c5f6dc] /w/index.php?title=Sp%C3%A9cial:Requ%C3%AAter& Error from line 183 of /../w/extensions/DisplayTitle/includes/DisplayTitleHooks.php: Call to a member function isTalkPage() on null

Backtrace

#0 /../w/includes/Hooks.php(174): DisplayTitleHooks::onParserBeforeStrip(Parser, string, NULL)
#1 /../w/includes/Hooks.php(202): Hooks::callHook(string, array, array, NULL)
#2 /../w/includes/parser/Parser.php(695): Hooks::run(string, array)
#3 /../w/extensions/SemanticResultFormats/formats/graphviz/SRF_Graph.php(136): Parser->recursiveTagParse(string)
#4 /../w/extensions/SemanticMediaWiki/src/Query/ResultPrinters/ResultPrinter.php(342): SRFGraph->getResultText(SMW\Query\QueryResult, integer)
#5 /../w/extensions/SemanticMediaWiki/src/Query/ResultPrinters/ResultPrinter.php(307): SMW\Query\ResultPrinters\ResultPrinter->buildResult(SMW\Query\QueryResult)
#6 /../w/extensions/SemanticMediaWiki/src/MediaWiki/Specials/SpecialAsk.php(481): SMW\Query\ResultPrinters\ResultPrinter->getResult(SMW\Query\QueryResult, array, integer)
#7 /../w/extensions/SemanticMediaWiki/src/MediaWiki/Specials/SpecialAsk.php(316): SMW\MediaWiki\Specials\SpecialAsk->fetchResults(SRFGraph, SMWQuery, SMW\MediaWiki\Specials\Ask\UrlArgs)
#8 /../w/extensions/SemanticMediaWiki/src/MediaWiki/Specials/SpecialAsk.php(169): SMW\MediaWiki\Specials\SpecialAsk->makeHTMLResult()
#9 /../w/includes/specialpage/SpecialPage.php(569): SMW\MediaWiki\Specials\SpecialAsk->execute(NULL)
#10 /../w/includes/specialpage/SpecialPageFactory.php(558): SpecialPage->run(NULL)
#11 /../w/includes/MediaWiki.php(288): MediaWiki\Special\SpecialPageFactory->executePath(Title, RequestContext)
#12 /../w/includes/MediaWiki.php(865): MediaWiki->performRequest()
#13 /../w/includes/MediaWiki.php(515): MediaWiki->main()
#14 /../w/index.php(42): MediaWiki->run()
#15 {main}

Event Timeline

Change 525191 had a related patch set uploaded (by Cicalese; owner: Cicalese):
[mediawiki/extensions/DisplayTitle@master] Check for null title

https://gerrit.wikimedia.org/r/525191

Thank you for the bug report, @Kghbln and @mwjames. Please let me know if the attached patch fixes the issue. Thanks!

@cicalese Thanks a lot for fixing. Now the next extension gives the same issue. :| Reported with T228881.

Change 525191 merged by jenkins-bot:
[mediawiki/extensions/DisplayTitle@master] Check for null title

https://gerrit.wikimedia.org/r/525191

@cicalese Probably worth doing a 2.0.1 release to also bring translation updates, etc. since the last release in 12.2017?

Good point. I'll try to get to that soon.

cicalese claimed this task.
cicalese moved this task from Doing to Closed on the User-Cicalese board.
cicalese moved this task from Backlog to Closed on the MediaWiki-extensions-DisplayTitle board.