Page MenuHomePhabricator
Create Task
Maniphest T228626

Extract interfaces and base classes from SearchResultSet and SearchResult
Closed, ResolvedPublic
Actions

Description

To let SearchEngines control how these objects are constructed.
Changing the signature of one the constructors in this hierarchy is currently nearly impossible.

Details

Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

dcausse created this task.Jul 22 2019, 9:24 AM
Restricted Application edited projects, added Discovery-Search; removed Discovery-Search (Current work). · View Herald TranscriptJul 22 2019, 9:24 AM
dcausse triaged this task as Medium priority.Jul 22 2019, 9:24 AM
dcausse moved this task from needs triage to making others happy on the Discovery-Search board.
dcausse moved this task from making others happy to Current work on the Discovery-Search board.
dcausse edited projects, added Discovery-Search (Current work); removed Discovery-Search.
dcausse renamed this task from Extract interfaces from SearchResultSet and SearchResultSet to Extract interfaces from SearchResultSet and SearchResult.Jul 22 2019, 9:28 AM
dcausse updated the task description. (Show Details)
gerritbot added a comment.Jul 22 2019, 3:39 PM

Change 524806 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/core@master] Deprecate SearchResultSet::free

https://gerrit.wikimedia.org/r/524806

gerritbot added a project: Patch-For-Review.Jul 22 2019, 3:39 PM

Change 524808 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/core@master] Add ISearchResultSet

https://gerrit.wikimedia.org/r/524808

gerritbot added a comment.Jul 22 2019, 5:44 PM

Change 524822 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/extensions/CirrusSearch@master] Use ISearchResultSet

https://gerrit.wikimedia.org/r/524822

gerritbot added a comment.Jul 22 2019, 5:45 PM

Change 524823 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/extensions/WikibaseLexemeCirrusSearch@master] Use ISearchResultSet

https://gerrit.wikimedia.org/r/524823

gerritbot added a comment.Jul 22 2019, 8:57 PM

Change 524806 merged by jenkins-bot:
[mediawiki/core@master] Deprecate SearchResultSet::free

https://gerrit.wikimedia.org/r/524806

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.15; 2019-07-23).Jul 22 2019, 9:00 PM
gerritbot added a comment.Jul 22 2019, 10:11 PM

Change 524808 merged by jenkins-bot:
[mediawiki/core@master] Add ISearchResultSet

https://gerrit.wikimedia.org/r/524808

gerritbot added a comment.Jul 22 2019, 10:12 PM

Change 524822 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Use ISearchResultSet

https://gerrit.wikimedia.org/r/524822

EBernhardson mentioned this in rECIRb315ee0df17b: Use ISearchResultSet.Jul 22 2019, 10:13 PM
gerritbot added a comment.Jul 23 2019, 2:34 PM

Change 525101 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/core@master] Add ISearchResult

https://gerrit.wikimedia.org/r/525101

gerritbot added a comment.Jul 23 2019, 2:35 PM

Change 525102 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/extensions/WikibaseLexemeCirrusSearch@master] Use ISearchResult

https://gerrit.wikimedia.org/r/525102

gerritbot added a comment.Jul 23 2019, 2:35 PM

Change 525103 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/extensions/Wikibase@master] Use ISearchResult

https://gerrit.wikimedia.org/r/525103

gerritbot added a comment.Jul 23 2019, 2:40 PM

Change 525104 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/extensions/WikibaseCirrusSearch@master] Use ISearchResult

https://gerrit.wikimedia.org/r/525104

EBernhardson moved this task from Incoming to Needs review on the Discovery-Search (Current work) board.Jul 23 2019, 5:38 PM
gerritbot added a comment.Jul 25 2019, 12:38 PM

Change 525101 abandoned by DCausse:
Add ISearchResult

https://gerrit.wikimedia.org/r/525101

gerritbot added a comment.Jul 25 2019, 12:39 PM

Change 525103 abandoned by DCausse:
Use ISearchResult

https://gerrit.wikimedia.org/r/525103

gerritbot added a comment.Jul 25 2019, 12:39 PM

Change 525104 abandoned by DCausse:
Use ISearchResult

https://gerrit.wikimedia.org/r/525104

gerritbot added a comment.Jul 25 2019, 12:39 PM

Change 525102 abandoned by DCausse:
Use ISearchResult

https://gerrit.wikimedia.org/r/525102

gerritbot added a comment.Jul 25 2019, 12:40 PM

Change 525528 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/core@master] Add BaseSearchResultSet

https://gerrit.wikimedia.org/r/525528

gerritbot added a comment.Jul 25 2019, 1:50 PM

Change 525543 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/core@master] Add SearchResultSetTrait

https://gerrit.wikimedia.org/r/525543

dcausse renamed this task from Extract interfaces from SearchResultSet and SearchResult to Extract interfaces and base classes from SearchResultSet and SearchResult.Jul 26 2019, 3:50 PM
gerritbot added a comment.Jul 26 2019, 3:52 PM

Change 525834 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/extensions/CirrusSearch@master] Add CirrusSearchResultSet and type hint against it

https://gerrit.wikimedia.org/r/525834

gerritbot added a comment.Jul 26 2019, 4:51 PM

Change 525844 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/extensions/WikibaseCirrusSearch@master] Use Cirrus abstract class for SearchResultSet and ResultsType

https://gerrit.wikimedia.org/r/525844

gerritbot added a comment.Jul 26 2019, 4:56 PM

Change 525845 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/extensions/WikibaseLexemeCirrusSearch@master] Use Cirrus abstract class for SearchResultSet and ResultsType

https://gerrit.wikimedia.org/r/525845

EBernhardson moved this task from Needs review to Needs Reporting on the Discovery-Search (Current work) board.Jul 30 2019, 12:14 AM
gerritbot added a comment.Jul 30 2019, 1:29 AM

Change 525528 merged by jenkins-bot:
[mediawiki/core@master] Add BaseSearchResultSet

https://gerrit.wikimedia.org/r/525528

gerritbot added a comment.Jul 30 2019, 1:30 AM

Change 525543 merged by jenkins-bot:
[mediawiki/core@master] Add SearchResultSetTrait

https://gerrit.wikimedia.org/r/525543

ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.16; 2019-07-30); removed MW-1.34-notes (1.34.0-wmf.15; 2019-07-23).Jul 30 2019, 2:00 AM
dcausse moved this task from Needs Reporting to Incoming on the Discovery-Search (Current work) board.Jul 30 2019, 5:26 PM
gerritbot added a comment.Aug 1 2019, 9:22 PM

Change 527216 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/core@master] Hard deprecate new SearchResult() and introduce RevisionSearchResult

https://gerrit.wikimedia.org/r/527216

gerritbot added a comment.Aug 21 2019, 9:31 AM

Change 531451 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/core@master] Make SearchResult an abstract base class

https://gerrit.wikimedia.org/r/531451

dcausse moved this task from Incoming to Needs review on the Discovery-Search (Current work) board.Aug 21 2019, 9:31 AM
gerritbot added a comment.Aug 21 2019, 10:40 PM

Change 524823 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexemeCirrusSearch@master] Use ISearchResultSet

https://gerrit.wikimedia.org/r/524823

ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.20; 2019-08-27); removed MW-1.34-notes (1.34.0-wmf.16; 2019-07-30).Aug 21 2019, 11:00 PM
dcausse mentioned this in rEWLCb09b92087e88: Use ISearchResultSet.Aug 21 2019, 11:53 PM
gerritbot added a comment.Aug 27 2019, 3:53 PM

Change 527216 merged by jenkins-bot:
[mediawiki/core@master] Hard deprecate new SearchResult() and introduce RevisionSearchResult

https://gerrit.wikimedia.org/r/527216

ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.21; 2019-09-03); removed MW-1.34-notes (1.34.0-wmf.20; 2019-08-27).Aug 27 2019, 4:04 PM
gerritbot added a comment.Sep 4 2019, 8:59 PM

Change 525834 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Add CirrusSearchResultSet and type hint against it

https://gerrit.wikimedia.org/r/525834

dcausse mentioned this in rECIR62006d4eefa1: Add CirrusSearchResultSet and type hint against it.Sep 4 2019, 9:00 PM
gerritbot added a comment.Sep 4 2019, 9:28 PM

Change 525844 merged by jenkins-bot:
[mediawiki/extensions/WikibaseCirrusSearch@master] Use Cirrus abstract class for SearchResultSet and ResultsType

https://gerrit.wikimedia.org/r/525844

gerritbot added a comment.Sep 4 2019, 9:28 PM

Change 525845 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexemeCirrusSearch@master] Use Cirrus abstract class for SearchResultSet and ResultsType

https://gerrit.wikimedia.org/r/525845

dcausse mentioned this in rEWLC069916b5973e: Use Cirrus abstract class for SearchResultSet and ResultsType.Sep 4 2019, 9:40 PM
ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.22; 2019-09-10); removed MW-1.34-notes (1.34.0-wmf.21; 2019-09-03).Sep 4 2019, 10:00 PM
dcausse mentioned this in rEWCS9f6861323010: Use Cirrus abstract class for SearchResultSet and ResultsType.Sep 4 2019, 10:14 PM
dcausse moved this task from Needs review to Needs Reporting on the Discovery-Search (Current work) board.Sep 9 2019, 1:19 PM
debt closed this task as Resolved.Sep 20 2019, 4:35 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL