Page MenuHomePhabricator

Show the error when save fails, hide when leaving edit mode
Closed, ResolvedPublic

Description

  • have a boolean showError local field on the Termbox component to indicate the error state, set to false on initialization, and deactivateEditMode. Set to true in the catch block of the save method
  • plug messages into the MessageBanner component, show/hide with showError

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 22 2019, 10:27 AM
Jakob_WMDE moved this task from To Do to Doing on the Wikibase-Termbox-Iteration-20 board.

Change 527557 had a related patch set uploaded (by Jakob; owner: Jakob):
[wikibase/termbox@master] Show an error when failing to save an edit

https://gerrit.wikimedia.org/r/527557

Tarrow moved this task from Done to Peer Review on the Wikibase-Termbox-Iteration-20 board.

Change 527557 merged by jenkins-bot:
[wikibase/termbox@master] Show an error when failing to save an edit

https://gerrit.wikimedia.org/r/527557

Ladsgroup closed this task as Resolved.Oct 23 2019, 11:12 AM