Page MenuHomePhabricator
Create Task
Maniphest T228654

Modularize store
Closed, ResolvedPublic
Actions

Description

Statements and Snak should live in their own submodules in the store to:

  • avoid polluting the Entity module
  • gain more flexibility
  • increase reuseability

Details

Show related patches Customize query in gerrit

Event Timeline

• Matthias_Geisler_WMDE created this task.Jul 22 2019, 12:21 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 22 2019, 12:21 PM
• Matthias_Geisler_WMDE claimed this task.Jul 22 2019, 12:21 PM
• Matthias_Geisler_WMDE added a project: Wikidata.
• Matthias_Geisler_WMDE moved this task from To do to Doing on the Wikidata-Bridge-Sprint-2 board.
gerritbot added a comment.Jul 25 2019, 8:39 AM

Change 524546 had a related patch set uploaded (by Matthias Geisler; owner: Matthias Geisler):
[mediawiki/extensions/Wikibase@master] bridge: State for Snaks

https://gerrit.wikimedia.org/r/524546

gerritbot added a project: Patch-For-Review.Jul 25 2019, 8:39 AM

Change 524547 had a related patch set uploaded (by Matthias Geisler; owner: Matthias Geisler):
[mediawiki/extensions/Wikibase@master] bridge: Snaks Mutations

https://gerrit.wikimedia.org/r/524547

gerritbot added a comment.Jul 25 2019, 8:39 AM

Change 524548 had a related patch set uploaded (by Matthias Geisler; owner: Matthias Geisler):
[mediawiki/extensions/Wikibase@master] bridge: Snaks Getter

https://gerrit.wikimedia.org/r/524548

gerritbot added a comment.Jul 25 2019, 8:39 AM

Change 524549 had a related patch set uploaded (by Matthias Geisler; owner: Matthias Geisler):
[mediawiki/extensions/Wikibase@master] bridge: Snaks Actions

https://gerrit.wikimedia.org/r/524549

gerritbot added a comment.Jul 25 2019, 8:39 AM

Change 524570 had a related patch set uploaded (by Matthias Geisler; owner: Matthias Geisler):
[mediawiki/extensions/Wikibase@master] bridge: State for Statements

https://gerrit.wikimedia.org/r/524570

gerritbot added a comment.Jul 25 2019, 8:40 AM

Change 524571 had a related patch set uploaded (by Matthias Geisler; owner: Matthias Geisler):
[mediawiki/extensions/Wikibase@master] bridge: Statement Mutations

https://gerrit.wikimedia.org/r/524571

gerritbot added a comment.Jul 25 2019, 8:40 AM

Change 524582 had a related patch set uploaded (by Matthias Geisler; owner: Matthias Geisler):
[mediawiki/extensions/Wikibase@master] bridge: Statement Getter

https://gerrit.wikimedia.org/r/524582

gerritbot added a comment.Jul 25 2019, 8:40 AM

Change 525034 had a related patch set uploaded (by Matthias Geisler; owner: Matthias Geisler):
[mediawiki/extensions/Wikibase@master] bridge: Statement Actions

https://gerrit.wikimedia.org/r/525034

gerritbot added a comment.Jul 25 2019, 8:40 AM

Change 525495 had a related patch set uploaded (by Matthias Geisler; owner: Matthias Geisler):
[mediawiki/extensions/Wikibase@master] bridge: wireup statement module

https://gerrit.wikimedia.org/r/525495

• Matthias_Geisler_WMDE moved this task from Doing to Peer Review on the Wikidata-Bridge-Sprint-2 board.Jul 25 2019, 8:50 AM
WMDE-leszek added a project: Wikidata-Bridge-Sprint-3.Jul 31 2019, 8:38 AM
WMDE-leszek moved this task from To do to Peer Review on the Wikidata-Bridge-Sprint-3 board.
gerritbot added a comment.Aug 6 2019, 7:45 AM

Change 528386 had a related patch set uploaded (by Matthias Geisler; owner: Matthias Geisler):
[mediawiki/extensions/Wikibase@master] bridge: State for Statements

https://gerrit.wikimedia.org/r/528386

gerritbot added a comment.Aug 6 2019, 7:45 AM

Change 528387 had a related patch set uploaded (by Matthias Geisler; owner: Matthias Geisler):
[mediawiki/extensions/Wikibase@master] bridge: Statement Mutations

https://gerrit.wikimedia.org/r/528387

gerritbot added a comment.Aug 6 2019, 7:45 AM

Change 528388 had a related patch set uploaded (by Matthias Geisler; owner: Matthias Geisler):
[mediawiki/extensions/Wikibase@master] bridge: Statement Getter

https://gerrit.wikimedia.org/r/528388

gerritbot added a comment.Aug 6 2019, 7:46 AM

Change 528389 had a related patch set uploaded (by Matthias Geisler; owner: Matthias Geisler):
[mediawiki/extensions/Wikibase@master] bridge: Statement Actions

https://gerrit.wikimedia.org/r/528389

• Matthias_Geisler_WMDE moved this task from Peer Review to Doing on the Wikidata-Bridge-Sprint-3 board.Aug 6 2019, 7:46 AM
• Matthias_Geisler_WMDE moved this task from Doing to Peer Review on the Wikidata-Bridge-Sprint-3 board.Aug 7 2019, 11:47 AM
gerritbot added a comment.Aug 8 2019, 6:08 AM

Change 528735 had a related patch set uploaded (by Matthias Geisler; owner: Matthias Geisler):
[mediawiki/extensions/Wikibase@master] bridge: Snak Unit Getter

https://gerrit.wikimedia.org/r/528735

gerritbot added a comment.Aug 8 2019, 6:12 AM

Change 528736 had a related patch set uploaded (by Matthias Geisler; owner: Matthias Geisler):
[mediawiki/extensions/Wikibase@master] bridge: Wire up Snak Unit Getters with Statements

https://gerrit.wikimedia.org/r/528736

gerritbot added a comment.Aug 8 2019, 6:17 AM

Change 528737 had a related patch set uploaded (by Matthias Geisler; owner: Matthias Geisler):
[mediawiki/extensions/Wikibase@master] bridge: Snak Unit Mutations

https://gerrit.wikimedia.org/r/528737

gerritbot added a comment.Aug 8 2019, 8:12 AM

Change 528738 had a related patch set uploaded (by Matthias Geisler; owner: Matthias Geisler):
[mediawiki/extensions/Wikibase@master] bridge: wire up Snak Unit Mutations with Statements

https://gerrit.wikimedia.org/r/528738

gerritbot added a comment.Aug 8 2019, 8:14 AM

Change 528739 had a related patch set uploaded (by Matthias Geisler; owner: Matthias Geisler):
[mediawiki/extensions/Wikibase@master] bridge: Snak Unit Actions

https://gerrit.wikimedia.org/r/528739

gerritbot added a comment.Aug 8 2019, 8:23 AM

Change 528740 had a related patch set uploaded (by Matthias Geisler; owner: Matthias Geisler):
[mediawiki/extensions/Wikibase@master] bridge: wire Snak Unit Action with Statements

https://gerrit.wikimedia.org/r/528740

gerritbot added a comment.Aug 8 2019, 8:28 AM

Change 528741 had a related patch set uploaded (by Matthias Geisler; owner: Matthias Geisler):
[mediawiki/extensions/Wikibase@master] bridge: wire up statement module with store

https://gerrit.wikimedia.org/r/528741

gerritbot added a comment.Aug 15 2019, 2:07 PM

Change 528386 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: State for Statements

https://gerrit.wikimedia.org/r/528386

gerritbot added a comment.Aug 15 2019, 2:15 PM

Change 528387 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: Statement Mutations

https://gerrit.wikimedia.org/r/528387

gerritbot added a comment.Aug 15 2019, 2:15 PM

Change 528388 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: Statement Getter

https://gerrit.wikimedia.org/r/528388

gerritbot added a comment.Aug 15 2019, 2:19 PM

Change 528389 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: Statement Actions

https://gerrit.wikimedia.org/r/528389

gerritbot added a comment.Aug 15 2019, 2:31 PM

Change 528735 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: Snak Unit Getter

https://gerrit.wikimedia.org/r/528735

gerritbot added a comment.Aug 15 2019, 2:31 PM

Change 528736 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: Wire up Snak Unit Getters with Statements

https://gerrit.wikimedia.org/r/528736

gerritbot added a comment.Aug 15 2019, 2:39 PM

Change 528737 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: Snak Unit Mutations

https://gerrit.wikimedia.org/r/528737

gerritbot added a comment.Aug 15 2019, 3:51 PM

Change 528738 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: wire up Snak Unit Mutations with Statements

https://gerrit.wikimedia.org/r/528738

gerritbot added a comment.Aug 15 2019, 4:03 PM

Change 528739 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: Snak Unit Actions

https://gerrit.wikimedia.org/r/528739

gerritbot added a comment.Aug 15 2019, 4:03 PM

Change 528740 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: wire Snak Unit Action with Statements

https://gerrit.wikimedia.org/r/528740

gerritbot added a comment.Aug 15 2019, 4:48 PM

Change 528741 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: wire up statement module with store

https://gerrit.wikimedia.org/r/528741

• Pablo-WMDE closed this task as Resolved.Aug 15 2019, 5:00 PM
• Pablo-WMDE moved this task from Peer Review to Done on the Wikidata-Bridge-Sprint-3 board.
ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.20; 2019-08-27).Aug 20 2019, 8:01 PM
gerritbot added a comment.Jun 5 2020, 2:32 PM

Change 524546 abandoned by Lucas Werkmeister (WMDE):
bridge: State for Snaks

Reason:
We ended up going a different way with the store, without a dedicated Snaks module.

https://gerrit.wikimedia.org/r/524546

gerritbot added a comment.Jun 5 2020, 2:33 PM

Change 524547 abandoned by Lucas Werkmeister (WMDE):
bridge: Snaks Mutations

Reason:
We ended up going a different way with the store, without a dedicated Snaks module.

https://gerrit.wikimedia.org/r/524547

gerritbot added a comment.Jun 5 2020, 2:33 PM

Change 524548 abandoned by Lucas Werkmeister (WMDE):
bridge: Snaks Getter

Reason:
We ended up going a different way with the store, without a dedicated Snaks module.

https://gerrit.wikimedia.org/r/524548

gerritbot added a comment.Jun 5 2020, 2:33 PM

Change 524549 abandoned by Lucas Werkmeister (WMDE):
bridge: Snaks Actions

Reason:
We ended up going a different way with the store, without a dedicated Snaks module.

https://gerrit.wikimedia.org/r/524549

gerritbot added a comment.Jun 5 2020, 2:34 PM

Change 524570 abandoned by Lucas Werkmeister (WMDE):
bridge: State for Statements

Reason:
Superseded by I6882fdbc93.

https://gerrit.wikimedia.org/r/524570

gerritbot added a comment.Jun 5 2020, 2:34 PM

Change 524571 abandoned by Lucas Werkmeister (WMDE):
bridge: Statement Mutations

Reason:
Superseded by Id7e7a2258a.

https://gerrit.wikimedia.org/r/524571

gerritbot added a comment.Jun 5 2020, 2:35 PM

Change 524582 abandoned by Lucas Werkmeister (WMDE):
bridge: Statement Getter

Reason:
Superseded by I70ee7e1c88.

https://gerrit.wikimedia.org/r/524582

gerritbot added a comment.Jun 5 2020, 2:35 PM

Change 525034 abandoned by Lucas Werkmeister (WMDE):
bridge: Statement Actions

Reason:
Superseded by I0d0205df3a.

https://gerrit.wikimedia.org/r/525034

gerritbot added a comment.Jun 5 2020, 2:36 PM

Change 525495 abandoned by Lucas Werkmeister (WMDE):
bridge: wireup statement module

Reason:
Superseded by I34c4f5c1d6.

https://gerrit.wikimedia.org/r/525495

Maintenance_bot removed a project: Patch-For-Review.Jun 5 2020, 3:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL