Page MenuHomePhabricator

make-wmf-branch should fail as soon as the first command fails
Closed, DeclinedPublic

Description

As part of the branch cutting for the weekly train, we need to run the make-wmf-branch script in mediawiki/tools/release.git. If runs git many times. If one hasn't configured git correctly, all of those git invocations fails. The script should notice this and stop and report an error, instead of blindly continuing.

It's a PHP script. If it were a sh script, the correct approach would be to add "set -e -u -o popefile", but I don't know what the corresponding change in PHP would be.

Event Timeline

greg triaged this task as Low priority.Jul 22 2019, 9:32 PM
greg subscribed.

Agreed, setting to Low just because of the low usage of this tool and hopefully this would only be a one-time issue for new train deployers (that is, the example of the failure you gave).

make-wmf-branch is now superseded by branch.py. Can this task be closed as obsolete? @mmodell ?

Indeed, make-wmf-branch is no more.