Hi @Charlotte and cc @Dbrant

Not sure what kinds of additional notification types should we add into, and the following screenshot is what I've seen from the existing code:

It shows that the currently restricted notification types are related to the login status, are those types going to be added in this task?

Hey @cooltey - the other Echo notification types we want to enable are all listed here: https://www.mediawiki.org/wiki/Help:Notifications/Notifications_types

Right now, as you know, we only have Welcome, Milestone, and Thanks enabled. Now we want to notify people about reverts, mentions, etc. And LoginNotify (listed on that page) is one of them - but that doesn't seem to match the code snippet you've posted. Thoughts, @Dbrant?

LoginNotify (listed on that page) is one of them - but that doesn't seem to match the code snippet you've posted.

👍 Add it!

Note: notification categories from the API
https://phabricator.wikimedia.org/diffusion/ECHO/browse/master/extension.json$513

Hi @Charlotte

I checked the extension file above and found that there are so many types or categories from the API response. If we want to show "ALL" notification types (categories), should we remove the logic of setting preferences? (see the image below)

Or, should we follow the notification settings as same as the Wikipedia desktop? Not sure that fits the app ecosystem if shows all the notification settings.

Hi @cooltey - as memorialised in the standup call, we will mitigate the problem by:

• collapsing related notifications (mentions and login stuff, for example) into one setting
• not showing a separate setting for items the user is unlikely to want to turn on and off frequently ("connected to data repository", OAuth admin, etc)

Hi @Charlotte
I put the mention, mention-failure, and mention-success categories into one preference setting as mention

There few categories that I didn't put them into the app, such as user-rights, linked, article-reminder, and please let me know if you think it would be better to put them in the app.

Here's the current implementation:

I think that's perfect @cooltey - the three that you have left out are not going to be relevant for the vast majority of our users (and those who will want them have accounts that they use on the website anyway, where everything is configurable), so I think it is fine to leave them out.

Looks good to me on 2.7.50292-beta-2019-09-06