Page MenuHomePhabricator

New mobile context ("edit cards") do not support multiple context items very well
Open, Needs TriagePublic

Description

The context system is designed to allow for multiple context items to be present at a given offset.

Currently this is quite rare, but can be seen if the language annotation is used at the same time as a link, for example in the following wikitext:

<span lang="fr">[[Chien]]</span>

On desktop this looks like this:

image.png (289×415 px, 14 KB)

With the new mobile context its looks like this:

image.png (592×353 px, 32 KB)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
JTannerWMF subscribed.

Hey @Esanders I am moving this to the freezer as it appears to be an edge case, feel free to move it if you disagree.

Some quick experimentation suggests that the edit card can't scroll, if it manages to expand past the screen height. Worse, in that case, the top of the card containing the close button is stuck off the top of the screen, leaving the user in an unrecoverable state.

image.png (808×508 px, 44 KB)

This is fairly edge-casey, as you need either a very uncommon stack of annotations or a really small phone. That said, I think we should at least make the card scrollable in this situation.