Page MenuHomePhabricator
Create Task
Maniphest T228760

Fatal FailCommitException: "No page for workflow" (from Flow Workflow.php)
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error

Request URL: https://www.mediawiki.org/w/api.php
Request ID: XTcLYQpAMEIAAG0SiC0AAACO

message
[{exception_id}] {exception_url}   Flow\Exception\FailCommitException from line 122 of /srv/mediawiki/php-1.34.0-wmf.15/extensions/Flow/includes/Model/Workflow.php: No page for workflow: O:19:"Flow\Model\Workflow":10:{s:5:"
trace
#0 /srv/mediawiki/php-1.34.0-wmf.15/extensions/Flow/includes/Data/Mapper/CachingObjectMapper.php(65): Flow\Model\Workflow::toStorageRow(Flow\Model\Workflow)
#1 [internal function]: Flow\Data\Mapper\CachingObjectMapper->toStorageRow(Flow\Model\Workflow)
#2 /srv/mediawiki/php-1.34.0-wmf.15/extensions/Flow/includes/Data/ObjectManager.php(247): array_map(array, array)
#3 /srv/mediawiki/php-1.34.0-wmf.15/extensions/Flow/includes/Data/ObjectManager.php(173): Flow\Data\ObjectManager->insert(array, array)
#4 /srv/mediawiki/php-1.34.0-wmf.15/extensions/Flow/includes/Data/ObjectManager.php(146): Flow\Data\ObjectManager->multiPut(array, array)
#5 /srv/mediawiki/php-1.34.0-wmf.15/extensions/Flow/includes/Data/ManagerGroup.php(81): Flow\Data\ObjectManager->put(Flow\Model\Workflow, array)
#6 /srv/mediawiki/php-1.34.0-wmf.15/extensions/Flow/includes/Block/TopicListBlock.php(172): Flow\Data\ManagerGroup->put(Flow\Model\Workflow, array)
#7 /srv/mediawiki/php-1.34.0-wmf.15/extensions/Flow/includes/SubmissionHandler.php(160): Flow\Block\TopicListBlock->commit()
#8 /srv/mediawiki/php-1.34.0-wmf.15/extensions/Flow/includes/WorkflowLoader.php(66): Flow\SubmissionHandler->commit(Flow\Model\Workflow, array)
#9 /srv/mediawiki/php-1.34.0-wmf.15/extensions/Flow/includes/Api/ApiFlowBasePost.php(35): Flow\WorkflowLoader->commit(array)
#10 /srv/mediawiki/php-1.34.0-wmf.15/extensions/Flow/includes/Api/ApiFlow.php(101): Flow\Api\ApiFlowBasePost->execute()
#11 /srv/mediawiki/php-1.34.0-wmf.15/includes/api/ApiMain.php(1583): Flow\Api\ApiFlow->execute()
#12 /srv/mediawiki/php-1.34.0-wmf.15/includes/api/ApiMain.php(531): ApiMain->executeAction()
#13 /srv/mediawiki/php-1.34.0-wmf.15/includes/api/ApiMain.php(502): ApiMain->executeActionWithErrorHandling()
#14 /srv/mediawiki/php-1.34.0-wmf.15/api.php(86): ApiMain->execute()
#15 /srv/mediawiki/w/api.php(3): include(string)
#16 {main}

Impact

TBD

Notes

I don't have the PHP understanding to determine if this is a train blocker. Just in case, I'm marking it as one. If it isn't, please tell me. Thanks.

Event Timeline

• LarsWirzenius created this task.Jul 23 2019, 1:58 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 23 2019, 1:58 PM
• LarsWirzenius triaged this task as Unbreak Now! priority.Jul 23 2019, 1:58 PM
Restricted Application added a subscriber: Liuxinyu970226. · View Herald TranscriptJul 23 2019, 1:58 PM
Krinkle moved this task from Untriaged to Jul2019/1.34.wmf.13+ on the Wikimedia-production-error board.Jul 23 2019, 3:45 PM
Aklapper added projects: Platform Engineering, StructuredDiscussions.Jul 23 2019, 5:01 PM
Aklapper removed a subscriber: Platform Engineering.

Assuming this task is about StructuredDiscussions, hence adding project tag so others can find this task when searching for tasks under that code project.

Restricted Application added a project: Growth-Team. · View Herald TranscriptJul 23 2019, 5:01 PM
Anomie lowered the priority of this task from Unbreak Now! to Medium.Jul 23 2019, 6:09 PM
Anomie removed a parent task: T220740: 1.34.0-wmf.15 deployment blockers.
Anomie removed a project: Platform Engineering.
Anomie subscribed.

This does clearly seem to be about Flow. Untagging Platform Engineering.

1 occurrence doesn't seem enough to justify UBN or to block the train. Feel free to re-raise if this becomes a recurring issue.

JTannerWMF moved this task from Inbox to Triaged but Future on the Growth-Team board.Jul 23 2019, 8:12 PM
JTannerWMF subscribed.

The Growth-Team is not prioritizing this at this time because we are only work on Flow issues that inhibit users.

• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:06 PM
• LarsWirzenius unsubscribed.Feb 20 2020, 3:33 PM
Krinkle renamed this task from Workflow.php: No page for workflow to Fatal FailCommitException: "No page for workflow" (from Flow Workflow.php).Jun 25 2020, 7:12 PM
Krinkle subscribed.EditedJun 30 2020, 6:13 PM
In T228760#5358932, @JTannerWMF wrote:

The Growth-Team is not prioritizing this at this time because we are only work on Flow issues that inhibit users.

Note that while these originate from the API, this is not a case of robots using the API. It is the case of Flow's interrace re-using the API internally to do its work. This issue does affect users.

From the last week, there are seven reports in Logstash:

  1. 0a90405f-ca22-47bc-8a56-8f9f38795840 - Flow\SubmissionHandler::commit was called with $blocks set to an empty array or a falsy value. This indicates the blocks are not able to commit, so Flow\SubmissionHandler::commit should not be called.
  2. 1d54ab5a-69c4-4e25-a33f-873ff22b1417 - Flow\Exception\FailCommitException: Flow\SubmissionHandler::commit was called with $blocks set to an empty array or a falsy value. This indicates the blocks are not able to commit, so Flow\SubmissionHandler::commit should not be called.
  3. … see Logstash

It affecting the same user talk page repeatedly seems to suggest it wasn't random or intermittent either, but might point to a bug or configuration problem that is persistently affecting certain cases.

Etonkovidova subscribed.EditedAug 31 2020, 9:35 PM
  1. The page https://fr.wikipedia.org/wiki/Discussion_utilisateur:Braaark (no > at the end - since it make the title invalid) is not Flow -based (page_content_model: wikitext). The page gets archived periodically.
  1. There are more of the same error Flow\Exception\FailCommitException... on two pages in arwiki - the first page and the second page, total errors are 16 - see logstash

Both pages are not Flow-based.

Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:02 PM
Ladsgroup moved this task from Jul2019/1.34.wmf.13+ to Older on the Wikimedia-production-error board.Feb 10 2021, 9:29 PM
Ladsgroup moved this task from Older to Jul2019/1.34.wmf.13+ on the Wikimedia-production-error board.
Krinkle closed this task as Resolved.Mar 10 2021, 1:39 AM

No longer seeing entries in Logstash mediawiki-errors for message:FailCommitException AND message:"No page for workflow" (last 30 days).

Looks like part of it was resolved, and part of it changed to fail slightly differently which is tracked by other tasks already.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL