Page MenuHomePhabricator

Empty diff does not show "(No difference)" when it's retrieved from cache
Open, Needs TriagePublic

Description

When an empty diff is retrieved from cached the (No difference) text is not shown. When first viewing the diff the text is visible.

This seems to be independent from the diff engine. I could reproduce it with wikidiff2 and the default diff. See example below:

Not shown: https://en.wikipedia.org/w/index.php?title=Sweetener_World_Tour&diff=907513441&oldid=907473226&diffonly=1
There is a html comment where "(No difference)" should be shown: <!-- diff cache key enwiki:diff:wikidiff2:1.12:old-907473226:rev-907513441:1.8.1 -->

Event Timeline

A2093064 created this task.Jul 23 2019, 2:10 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 23 2019, 2:10 PM

I just had a quick look at this to check if it's a wikidiff2 specific problem. Seems not to be the case.

The general observation is that whenever the diff view is cached the (No difference) text does not show. - When it's not already cached ( e.g. when you see the diff for the first time ) (No difference) is visible. - This can be reproduced with every diff that has no difference. First viewing the diff shows the text, second time not.

e.g. https://en.wikipedia.org/w/index.php?diff=907532865&oldid=887393262&title=User:Christoph_Jauera_(WMDE)/Test&type=revision&diffmode=source

@A2093064 I will change the ticket to reflect what I just found out. I hope that's ok.

WMDE-Fisch renamed this task from Some protection edit doesn't show "(No difference)" to Empty diff does not show "(No difference)" when it's retrieved from cache.Jul 23 2019, 3:15 PM
WMDE-Fisch updated the task description. (Show Details)
Ammarpad removed a subscriber: Ammarpad.Sun, Oct 6, 12:00 AM