Page MenuHomePhabricator

StopForumSpam: add report-only mode
Closed, ResolvedPublic

Description

It'd be useful for testing and stuff if we can make StopForum spam almost readonly (not blocking), but actually logging what IPs would've been used

Saves doing some of the analytics manually

Event Timeline

Reedy renamed this task from Add logging/readyonly mode to Add logging/readonly/monitor mode.Jul 23 2019, 2:32 PM
sbassett triaged this task as Medium priority.Jul 23 2019, 7:31 PM

Could we piggy-back on what's there?

I think so yeah. Looks like the logging we want is already there, just to neuter the functionality. We might want to keep the output of the whitelisting (so they're not false positives) and then shove an if before the $result = [ 'stopforumspam-blocked', $ip ]; line with the config var, and then return true

Change 559927 had a related patch set uploaded (by SBassett; owner: SBassett):
[mediawiki/extensions/StopForumSpam@master] StopForumSpam - add Report Only mode

https://gerrit.wikimedia.org/r/559927

sbassett renamed this task from Add logging/readonly/monitor mode to StopForumSpam: add report only mode.Dec 20 2019, 6:29 PM
sbassett renamed this task from StopForumSpam: add report only mode to StopForumSpam: add report-only mode.

Change 559927 merged by jenkins-bot:
[mediawiki/extensions/StopForumSpam@master] StopForumSpam - add Report Only mode

https://gerrit.wikimedia.org/r/559927

Reedy assigned this task to sbassett.