Page MenuHomePhabricator

Add revision comparison ("diff") screen
Closed, ResolvedPublic

Description

Why are we doing this?

Diffs are often used by editors to contribute to RFC, RFA or other requests that require administrative attention. They are used as evidence to back-up claims of vandalism or abuse. Additionally, they allow users to see how an article has changed over time.

User story

As an editor or reader who uses the iOS app, I would like to be able to see how an article has changed over time. This helps me to understand how individual or cumulative edits have affected the article over time.

Proposed designs
Top of pageScrolled pageScrolled page, unedited line expanded
375_History -Compare revisions.png (1×750 px, 151 KB)
375a_History - Compare revisions - scroll.png (1×750 px, 147 KB)
375a_History - Compare revisions - unedited text expanded.png (1×750 px, 146 KB)
https://zpl.io/VYo6WdLhttps://zpl.io/25AwWOrhttps://zpl.io/bekNRNP
Design details
  • The older of the two revisions is shown on the left on LTR languages
  • Unedited lines are only shown if they are the two lines before or after an edit
  • Unedited lines can be expanded by tapping on 'show'
  • Edits that added bytes are highlighted in green and bolded
  • Edits that removed bytes are highlighted in red, bolded and struck through
  • The revision information in the header is collapsed on scroll (see second mock)

Event Timeline

JMinor renamed this task from Comparison screen to Add revision comparison ("diff") screen.Jul 23 2019, 9:22 PM
JMinor triaged this task as Medium priority.
cmadeo updated the task description. (Show Details)

Per our meeting: Consider changing the logic to only showing two lines before and after an edit, with the ability to hide and show these lines.

We're still going to show when un edited content blobs exist, but we're not going to give the ability to expand it