Page MenuHomePhabricator

Existing qualifiers do not appear in read-mode on the file page
Closed, ResolvedPublicBug

Description

User story: N/A

We have this: On files with existing qualifiers (e.g. https://test-commons.wikimedia.org/wiki/File:Head_of_calico_cat_with_open_eyes.jpg), the qualifiers appear as blank lines. Upon clicking "edit" on the statement, the qualifiers appear (and are editable) after a short delay. Upon saving, the qualifiers appear (and appear to be functional afterwards)

We want this: Qualifiers, even ones added before the latest release, should appear normally.

Screenshots (if possible):

Acceptance Criteria:

  • On pages with existing qualifiers, those qualifiers appear in read-mode

During development, please test the following:

  • Test this feature while logged in AND logged out
  • Test this feature on at least one mobile browser
  • Test that this feature works on the file page AND the Add Data step on UploadWizard (if applicable, some features only exist on one or the other)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptTue, Jul 23, 8:45 PM

Can you still reproduce this? Or anyone else?
I can see the qualifiers immediately, both logged in & out.

Matthias and I just spoke briefly about this and found another file that had this issue - it seems it's a temporary problem, possibly related to caching, that would be hard to demonstrate by one link in a Phabricator task. He's on it, though.

Cparle added a subscriber: Cparle.Wed, Jul 24, 2:24 PM

I could see it on test-commons earlier today, but can't now. Maybe 1.34.0-wmf.15 fixed it?

Change 525302 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/WikibaseMediaInfo@master] Fix formatValue abort handling

https://gerrit.wikimedia.org/r/525302

This may be something we'll want to cherry-pick (or postpone enabling other statement until new branch gets to commons, next Wed)

Change 525302 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Fix formatValue abort handling

https://gerrit.wikimedia.org/r/525302

Change 525537 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/WikibaseMediaInfo@wmf/1.34.0-wmf.15] Fix formatValue abort handling

https://gerrit.wikimedia.org/r/525537

Change 525537 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@wmf/1.34.0-wmf.15] Fix formatValue abort handling

https://gerrit.wikimedia.org/r/525537

Mentioned in SAL (#wikimedia-operations) [2019-07-25T16:53:45Z] <jforrester@deploy1001> Synchronized php-1.34.0-wmf.15/extensions/WikibaseMediaInfo/resources/statements/: T228807 Fix formatValue abort handling (duration: 00m 48s)

Confirmed fixed on test-commons.

Ramsey-WMF closed this task as Resolved.Wed, Jul 31, 7:41 PM

Fixed on production.