Page MenuHomePhabricator
Create Task
Maniphest T228841

test_mime_file_container of dry_api_tests.DryMimeTests is failing for Python 3.5+
Closed, ResolvedPublicBUG REPORT
Actions

Description

======================================================================
FAIL: test_mime_file_container (tests.dry_api_tests.DryMimeTests)
Test Request._build_mime_request encodes binary.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/wikimedia/pywikibot/tests/dry_api_tests.py", line 302, in test_mime_file_container
    self.assertNotEqual(body.find(file_content), -1)
AssertionError: -1 == -1
----------------------------------------------------------------------

https://travis-ci.org/wikimedia/pywikibot/jobs/562945415 for example

Details

SubjectRepoBranchLines +/-
Revert "[bugfix] T113120 is solved for Python 3.5+"pywikibot/coremaster+10 -8
Customize query in gerrit

Related Objects
Search...

Event Timeline

Xqt created this task.Jul 24 2019, 9:05 AM
Restricted Application added a project: Pywikibot. · View Herald TranscriptJul 24 2019, 9:05 AM
Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald Transcript
Xqt triaged this task as High priority.Jul 24 2019, 9:06 AM
Xqt changed the subtype of this task from "Task" to "Bug Report".
Xqt added a parent task: T225591: Make Travis and Appveyor pass again.
Xqt added a comment.Jul 24 2019, 9:41 AM

Either T113120 isn't really solved or the behaviour is different from Python 2. The fix works for Python 3.4 only since rPWBC07ce5ab6fe67.

Xqt renamed this task from test_mime_file_container of dry_api_tests.DryMimeTests is failing to test_mime_file_container of dry_api_tests.DryMimeTests is failing for Python 3.5+.Jul 24 2019, 9:41 AM
Xqt added subscribers: Dalba, Mpaa.
Dalba added a comment.EditedJul 24 2019, 1:17 PM
In T228841#5360477, @Xqt wrote:

Either T113120 isn't really solved or the behaviour is different from Python 2. The fix works for Python 3.4 only since rPWBC07ce5ab6fe67.

According to CPython's changelog, the fix for issue19003 has been published in Python 3.5.3 RC1. Therefore 3.5.0, 3.5.1, and 3.5.2 have that issue.
There is also another issue which is still not resolved: BytesGenerator does not handle 'binary' CTE correctly.

gerritbot added a comment.Jul 24 2019, 1:41 PM

Change 525285 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] Revert "[bugfix] T113120 is solved for Python 3.5+"

https://gerrit.wikimedia.org/r/525285

gerritbot added a project: Patch-For-Review.Jul 24 2019, 1:41 PM
gerritbot added a comment.Jul 24 2019, 1:46 PM

Change 525285 merged by jenkins-bot:
[pywikibot/core@master] Revert "[bugfix] T113120 is solved for Python 3.5+"

https://gerrit.wikimedia.org/r/525285

Xqt mentioned this in rPWBC96a2cb84a730: Revert "[bugfix] T113120 is solved for Python 3.5+".Jul 24 2019, 1:48 PM
Xqt closed this task as Resolved.Jul 24 2019, 1:52 PM
Xqt claimed this task.
Maintenance_bot removed a project: Patch-For-Review.Jul 24 2019, 2:10 PM
Xqt mentioned this in T334747: pywikibot.data.api.Request() import page error.Apr 21 2023, 2:38 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL