Page MenuHomePhabricator

Remove trailing newline from log messages
Closed, ResolvedPublic


Due to conversion from wfDebug, which required explicit newlines, we have approximately 100 log messages which end in a "\n". These are no longer necessary with the PSR-3 logging interface and should be removed from any single-line message.

Event Timeline

Note that wfDebugLog(); does a trim() on the message anyway :]

Change 582821 had a related patch set uploaded (by Hashar; owner: Hashar):
[mediawiki/extensions/Scribunto@master] Remove trailing newline from log messages

Change 582821 merged by jenkins-bot:
[mediawiki/extensions/Scribunto@master] Remove trailing newline from log messages

Aklapper changed the task status from Stalled to Open.Oct 19 2020, 4:26 PM

@hashar: Your patch has been merged; is there more work to do here or can this task be resolved?

Krinkle added a subscriber: Krinkle.

Seems so. This task is imho too broad if it was not meant to be about Scribunto. File individual tasks instead, or simply submit patches without a task.