Page MenuHomePhabricator
Create Task
Maniphest T228848

Remove trailing newline from log messages
Closed, ResolvedPublic
Actions

Description

Due to conversion from wfDebug, which required explicit newlines, we have approximately 100 log messages which end in a "\n". These are no longer necessary with the PSR-3 logging interface and should be removed from any single-line message.

Details

SubjectRepoBranchLines +/-
Remove trailing newline from log messagesmediawiki/extensions/Scribuntomaster+5 -5
Customize query in gerrit

Related Objects

Event Timeline

awight created this task.Jul 24 2019, 10:33 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 24 2019, 10:33 AM
hashar subscribed.Jul 24 2019, 12:01 PM

Note that wfDebugLog(); does a trim() on the message anyway :]

Anomie moved this task from Inbox to Triage Meeting Inbox on the Platform Engineering board.Jul 24 2019, 2:06 PM
CCicalese_WMF triaged this task as Low priority.Jul 30 2019, 5:54 PM
CCicalese_WMF edited projects, added Platform Team Workboards (Clinic Duty Team); removed Platform Engineering.
daniel moved this task from Inbox to Backlog on the Platform Team Workboards (Clinic Duty Team) board.Oct 8 2019, 9:57 AM
• AMooney changed the task status from Open to Stalled.Mar 12 2020, 1:22 PM
• AMooney edited projects, added Platform Engineering; removed Platform Team Workboards (Clinic Duty Team).
CCicalese_WMF moved this task from Triage Meeting Inbox to Icebox on the Platform Engineering board.Mar 12 2020, 1:46 PM
WDoranWMF edited projects, added Platform Engineering (Icebox); removed Platform Engineering.Mar 23 2020, 2:05 PM
gerritbot added a comment.Mar 23 2020, 2:46 PM

Change 582821 had a related patch set uploaded (by Hashar; owner: Hashar):
[mediawiki/extensions/Scribunto@master] Remove trailing newline from log messages

https://gerrit.wikimedia.org/r/582821

gerritbot added a project: Patch-For-Review.Mar 23 2020, 2:46 PM
gerritbot added a comment.Mar 23 2020, 2:58 PM

Change 582821 merged by jenkins-bot:
[mediawiki/extensions/Scribunto@master] Remove trailing newline from log messages

https://gerrit.wikimedia.org/r/582821

jenkins-bot mentioned this in rELUAfda6a663aa36: Remove trailing newline from log messages.Mar 23 2020, 2:59 PM
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.25; 2020-03-24).Mar 23 2020, 3:00 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 23 2020, 3:10 PM
Aklapper changed the task status from Stalled to Open.Oct 19 2020, 4:26 PM

@hashar: Your patch has been merged; is there more work to do here or can this task be resolved?

Krinkle closed this task as Resolved.Jan 7 2021, 11:41 PM
Krinkle subscribed.

Seems so. This task is imho too broad if it was not meant to be about Scribunto. File individual tasks instead, or simply submit patches without a task.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL